From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>,
Cleber Rosa <crosa@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel@nongnu.org, "Willian Rampazzo" <wrampazz@redhat.com>
Subject: Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test
Date: Thu, 7 Nov 2019 19:00:23 +0100 [thread overview]
Message-ID: <77a6200c-7f53-4305-1aad-4574f0faa904@redhat.com> (raw)
In-Reply-To: <bb0c5db0-899e-c5a6-caa3-add8bf64f780@vivier.eu>
On 11/7/19 6:18 PM, Laurent Vivier wrote:
> Le 07/11/2019 à 17:38, Cleber Rosa a écrit :
>> ----- Original Message -----
>>> From: "Eric Blake" <eblake@redhat.com>
>>> To: "Cleber Rosa" <crosa@redhat.com>, qemu-devel@nongnu.org
>>> Cc: "Peter Maydell" <peter.maydell@linaro.org>, "Eduardo Habkost" <ehabkost@redhat.com>, "Philippe Mathieu-Daudé"
>>> <f4bug@amsat.org>, "Wainer dos Santos Moschetta" <wainersm@redhat.com>, "Laurent Vivier" <laurent@vivier.eu>,
>>> "Willian Rampazzo" <wrampazz@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>
>>> Sent: Thursday, November 7, 2019 10:43:08 AM
>>> Subject: Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test
>>>
>>> On 10/29/19 6:23 PM, Cleber Rosa wrote:
>>>> The boot_linux_console.py:BootLinuxConsole.test_m68k_q800 was very
>>>> recently merged, but between its last review and now, the Kernel
>>>> package used went missing.
>>>>
>>>
>>> meta-question: Why was this series posted in-reply-to the pull request,
>>> rather than as a new top-level thread? I nearly missed it because I
>>> don't expect to see unreviewed patches buried in threading like that.
>>> My workflow would have been to post the series in isolation, then
>>> manually reply to the pull request to mention the message-id of the
>>> related series proposed as a followup.
>>>
>>
>> Hi Eric,
>>
>> That was my attempt to signal that it was a fix to something which had *just*
>> being merged as part of that pull request (though now caused by it).
>>
>> I basically did not know how to act properly, so I thank you for the workflow
>> suggestion. I'll certainly follow it next time.
>
> IMHO, you should send your series and then replies to the pull request
> to tell you have sent your series that fixes the patch in the pull
> request, or vice-versa.
>
> But your series has been queued by Alex, so there is no problem...
I prepared a different fix around the same time, but closed my laptop
before the patch was sent and noticed the next day:
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg08120.html
Laurent, are you OK with the new kernel being tested?
next prev parent reply other threads:[~2019-11-07 18:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 18:16 [PULL 00/11] Q800 branch patches Laurent Vivier
2019-10-28 18:16 ` [PULL 01/11] esp: move handle_ti_cmd() cleanup code to esp_do_dma() Laurent Vivier
2019-10-28 18:16 ` [PULL 02/11] esp: move get_cmd() post-DMA code to get_cmd_cb() Laurent Vivier
2019-10-28 18:16 ` [PULL 03/11] esp: add pseudo-DMA as used by Macintosh Laurent Vivier
2019-10-28 18:16 ` [PULL 04/11] dp8393x: manage big endian bus Laurent Vivier
2019-10-28 18:16 ` [PULL 05/11] hw/m68k: add VIA support Laurent Vivier
2019-10-28 18:16 ` [PULL 06/11] hw/m68k: implement ADB bus support for via Laurent Vivier
2019-10-28 18:16 ` [PULL 07/11] hw/m68k: add Nubus support Laurent Vivier
2019-10-28 18:16 ` [PULL 08/11] hw/m68k: add Nubus macfb video card Laurent Vivier
2019-10-28 18:16 ` [PULL 09/11] hw/m68k: add a dummy SWIM floppy controller Laurent Vivier
2019-10-28 18:16 ` [PULL 10/11] hw/m68k: define Macintosh Quadra 800 Laurent Vivier
2019-10-28 18:16 ` [PULL 11/11] BootLinuxConsoleTest: Test the " Laurent Vivier
2019-10-29 23:23 ` [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test Cleber Rosa
2019-10-29 23:23 ` [PATCH 1/2] Acceptance test: cancel test if m68k kernel packages goes missing Cleber Rosa
2019-10-31 8:06 ` Alex Bennée
2019-10-29 23:23 ` [PATCH 2/2] Acceptance test: update kernel for m68k/q800 test Cleber Rosa
2019-10-31 6:08 ` Alex Bennée
2019-11-07 15:08 ` Wainer dos Santos Moschetta
2019-10-31 8:06 ` Alex Bennée
2019-10-31 9:57 ` [PATCH 0/2] Acceptance test: update kernel used on " Alex Bennée
2019-11-07 15:43 ` Eric Blake
2019-11-07 16:38 ` Cleber Rosa
2019-11-07 17:18 ` Laurent Vivier
2019-11-07 18:00 ` Philippe Mathieu-Daudé [this message]
2019-11-07 18:25 ` Laurent Vivier
2019-10-28 23:55 ` [PULL 00/11] Q800 branch patches no-reply
2019-10-29 18:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a6200c-7f53-4305-1aad-4574f0faa904@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).