From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Corey Minyard" <minyard@acm.org>,
"Juan Quintela" <quintela@redhat.com>,
qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Markus Armbruster" <armbru@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 10/14] target/ppc: Rewrite a fall through comment
Date: Wed, 21 Aug 2019 13:19:43 +0200 [thread overview]
Message-ID: <20190821111947.26580-11-laurent@vivier.eu> (raw)
In-Reply-To: <20190821111947.26580-1-laurent@vivier.eu>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:
target/ppc/mmu_helper.c: In function ‘dump_mmu’:
target/ppc/mmu_helper.c:1349:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
1349 | if (ppc64_v3_radix(env_archcpu(env))) {
| ^
target/ppc/mmu_helper.c:1356:5: note: here
1356 | default:
| ^~~~~~~
cc1: all warnings being treated as errors
Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.
Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20190719131425.10835-6-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target/ppc/mmu_helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
index 55f7a7f16a12..86c667b09415 100644
--- a/target/ppc/mmu_helper.c
+++ b/target/ppc/mmu_helper.c
@@ -100,7 +100,7 @@ static int pp_check(int key, int pp, int nx)
case 0x1:
case 0x2:
access |= PAGE_WRITE;
- /* No break here */
+ /* fall through */
case 0x3:
access |= PAGE_READ;
break;
@@ -708,7 +708,7 @@ static int mmu40x_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
if (pr != 0) {
goto check_perms;
}
- /* No break here */
+ /* fall through */
case 0x3:
/* All accesses granted */
ctx->prot = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
@@ -722,7 +722,7 @@ static int mmu40x_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx,
ret = -2;
break;
}
- /* No break here */
+ /* fall through */
case 0x1:
check_perms:
/* Check from TLB entry */
--
2.21.0
next prev parent reply other threads:[~2019-08-21 11:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 11:19 [Qemu-devel] [PULL 00/14] Trivial branch patches Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 01/14] test: Use g_strndup instead of plain strndup Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 02/14] misc: fix naming scheme of compatiblity arrays Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 04/14] configure: fix sdl detection using sdl2-config Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 06/14] hw/net/e1000: Fix erroneous comment Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 08/14] hw/dma/omap_dma: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment Laurent Vivier
2019-08-21 11:48 ` Corey Minyard
2019-08-21 11:19 ` Laurent Vivier [this message]
2019-08-21 11:19 ` [Qemu-devel] [PULL 11/14] vl: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 12/14] spapr_events: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 13/14] hw/display/sm501: Remove unused include Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 14/14] hw/display: Compile various display devices as common object Laurent Vivier
2019-08-22 9:30 ` [Qemu-devel] [PULL 00/14] Trivial branch patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821111947.26580-11-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=minyard@acm.org \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).