qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Corey Minyard" <minyard@acm.org>,
	"Juan Quintela" <quintela@redhat.com>,
	qemu-trivial@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 04/14] configure: fix sdl detection using sdl2-config
Date: Wed, 21 Aug 2019 13:19:37 +0200	[thread overview]
Message-ID: <20190821111947.26580-5-laurent@vivier.eu> (raw)
In-Reply-To: <20190821111947.26580-1-laurent@vivier.eu>

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>

If SDL2 is requested but pkg-config doesn't have a module for it
configure should fallback to use sdl*-config, but wasn't able to
because and old variable (from SDL) was being used by mistake.

Correct the variable name and complete other related changes so
there are no more references to the old SDL.

Fixes: 0015ca5cbabe ("ui: remove support for SDL1.2 in favour of SDL2")
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20190710225528.409-1-carenas@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 configure | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 4e7b79c826a2..cc5ce7940582 100755
--- a/configure
+++ b/configure
@@ -3022,15 +3022,15 @@ fi
 ##########################################
 # SDL probe
 
-# Look for sdl configuration program (pkg-config or sdl-config).  Try
-# sdl-config even without cross prefix, and favour pkg-config over sdl-config.
+# Look for sdl configuration program (pkg-config or sdl2-config).  Try
+# sdl2-config even without cross prefix, and favour pkg-config over sdl2-config.
 
 sdl_probe ()
 {
   if $pkg_config sdl2 --exists; then
     sdlconfig="$pkg_config sdl2"
     sdlversion=$($sdlconfig --modversion 2>/dev/null)
-  elif has ${sdl_config}; then
+  elif has "$sdl2_config"; then
     sdlconfig="$sdl2_config"
     sdlversion=$($sdlconfig --version)
   else
@@ -3041,7 +3041,7 @@ sdl_probe ()
     # no need to do the rest
     return
   fi
-  if test -n "$cross_prefix" && test "$(basename "$sdlconfig")" = sdl-config; then
+  if test -n "$cross_prefix" && test "$(basename "$sdlconfig")" = sdl2-config; then
     echo warning: using "\"$sdlconfig\"" to detect cross-compiled sdl >&2
   fi
 
@@ -8023,7 +8023,6 @@ preserve_env PKG_CONFIG
 preserve_env PKG_CONFIG_LIBDIR
 preserve_env PKG_CONFIG_PATH
 preserve_env PYTHON
-preserve_env SDL_CONFIG
 preserve_env SDL2_CONFIG
 preserve_env SMBD
 preserve_env STRIP
-- 
2.21.0



  parent reply	other threads:[~2019-08-21 11:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 11:19 [Qemu-devel] [PULL 00/14] Trivial branch patches Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 01/14] test: Use g_strndup instead of plain strndup Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 02/14] misc: fix naming scheme of compatiblity arrays Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable Laurent Vivier
2019-08-21 11:19 ` Laurent Vivier [this message]
2019-08-21 11:19 ` [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 06/14] hw/net/e1000: Fix erroneous comment Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 08/14] hw/dma/omap_dma: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment Laurent Vivier
2019-08-21 11:48   ` Corey Minyard
2019-08-21 11:19 ` [Qemu-devel] [PULL 10/14] target/ppc: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 11/14] vl: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 12/14] spapr_events: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 13/14] hw/display/sm501: Remove unused include Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 14/14] hw/display: Compile various display devices as common object Laurent Vivier
2019-08-22  9:30 ` [Qemu-devel] [PULL 00/14] Trivial branch patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821111947.26580-5-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=armbru@redhat.com \
    --cc=carenas@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=minyard@acm.org \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).