* [PULL 0/2] Tracing patches
@ 2019-10-14 8:57 Stefan Hajnoczi
2019-10-14 8:57 ` [PULL 1/2] trace: add --group=all to tracing.txt Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:57 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Jason Wang,
Stefan Hajnoczi, Paolo Bonzini
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to a1f4fc951a277c49a25418cafb028ec5529707fa:
trace: avoid "is" with a literal Python 3.8 warnings (2019-10-14 09:54:46 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefan Hajnoczi (2):
trace: add --group=all to tracing.txt
trace: avoid "is" with a literal Python 3.8 warnings
docs/devel/tracing.txt | 3 ++-
scripts/tracetool/__init__.py | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PULL 1/2] trace: add --group=all to tracing.txt
2019-10-14 8:57 [PULL 0/2] Tracing patches Stefan Hajnoczi
@ 2019-10-14 8:57 ` Stefan Hajnoczi
2019-10-14 9:08 ` Philippe Mathieu-Daudé
2019-10-14 8:57 ` [PULL 2/2] trace: avoid "is" with a literal Python 3.8 warnings Stefan Hajnoczi
2019-10-15 12:24 ` [PULL 0/2] Tracing patches Peter Maydell
2 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:57 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Daniel P . Berrangé,
qemu-block, Philippe Mathieu-Daudé,
Jason Wang, Stefan Hajnoczi, Paolo Bonzini
tracetool needs to know the group name ("all", "root", or a specific
subdirectory). Also remove the stdin redirection because tracetool.py
needs the path to the trace-events file. Update the documentation.
Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191009135154.10970-1-stefanha@redhat.com>
---
docs/devel/tracing.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 8231bbf5d1..8c0376fefa 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -317,7 +317,8 @@ probes:
--binary path/to/qemu-binary \
--target-type system \
--target-name x86_64 \
- <trace-events-all >qemu.stp
+ --group=all \
+ trace-events-all >qemu.stp
To facilitate simple usage of systemtap where there merely needs to be printf
logging of certain probes, a helper script "qemu-trace-stap" is provided.
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PULL 2/2] trace: avoid "is" with a literal Python 3.8 warnings
2019-10-14 8:57 [PULL 0/2] Tracing patches Stefan Hajnoczi
2019-10-14 8:57 ` [PULL 1/2] trace: add --group=all to tracing.txt Stefan Hajnoczi
@ 2019-10-14 8:57 ` Stefan Hajnoczi
2019-10-15 12:24 ` [PULL 0/2] Tracing patches Peter Maydell
2 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:57 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, Daniel P . Berrangé,
qemu-block, Philippe Mathieu-Daudé,
Jason Wang, Stefan Hajnoczi, Paolo Bonzini
The following statement produces a SyntaxWarning with Python 3.8:
if len(format) is 0:
scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did you mean "=="?
Use the conventional len(x) == 0 syntax instead.
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191010122154.10553-1-stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
scripts/tracetool/__init__.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index 04279fa62e..44c118bc2a 100644
--- a/scripts/tracetool/__init__.py
+++ b/scripts/tracetool/__init__.py
@@ -456,12 +456,12 @@ def generate(events, group, format, backends,
import tracetool
format = str(format)
- if len(format) is 0:
+ if len(format) == 0:
raise TracetoolError("format not set")
if not tracetool.format.exists(format):
raise TracetoolError("unknown format: %s" % format)
- if len(backends) is 0:
+ if len(backends) == 0:
raise TracetoolError("no backends specified")
for backend in backends:
if not tracetool.backend.exists(backend):
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PULL 1/2] trace: add --group=all to tracing.txt
2019-10-14 8:57 ` [PULL 1/2] trace: add --group=all to tracing.txt Stefan Hajnoczi
@ 2019-10-14 9:08 ` Philippe Mathieu-Daudé
2019-10-15 8:45 ` Stefan Hajnoczi
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-14 9:08 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel, Thomas Huth
Cc: Fam Zheng, Peter Maydell, Daniel P . Berrangé,
qemu-block, Jason Wang, Paolo Bonzini
Hi Stefan,
On 10/14/19 10:57 AM, Stefan Hajnoczi wrote:
> tracetool needs to know the group name ("all", "root", or a specific
> subdirectory). Also remove the stdin redirection because tracetool.py
> needs the path to the trace-events file. Update the documentation.
>
> Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
> ("trace: move setting of group name into Makefiles")
> Launchpad: https://bugs.launchpad.net/bugs/1844814
Sorry I didn't noticed that earlier, but on
https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
we recommend using the 'Buglink' tag.
Not sure it's worth resending another pull request...
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Message-Id: <20191009135154.10970-1-stefanha@redhat.com>
> ---
> docs/devel/tracing.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
> index 8231bbf5d1..8c0376fefa 100644
> --- a/docs/devel/tracing.txt
> +++ b/docs/devel/tracing.txt
> @@ -317,7 +317,8 @@ probes:
> --binary path/to/qemu-binary \
> --target-type system \
> --target-name x86_64 \
> - <trace-events-all >qemu.stp
> + --group=all \
> + trace-events-all >qemu.stp
>
> To facilitate simple usage of systemtap where there merely needs to be printf
> logging of certain probes, a helper script "qemu-trace-stap" is provided.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL 1/2] trace: add --group=all to tracing.txt
2019-10-14 9:08 ` Philippe Mathieu-Daudé
@ 2019-10-15 8:45 ` Stefan Hajnoczi
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2019-10-15 8:45 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Thomas Huth, Daniel P . Berrangé,
qemu-block, Jason Wang, qemu-devel, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, Oct 14, 2019 at 11:08:25AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 10/14/19 10:57 AM, Stefan Hajnoczi wrote:
> > tracetool needs to know the group name ("all", "root", or a specific
> > subdirectory). Also remove the stdin redirection because tracetool.py
> > needs the path to the trace-events file. Update the documentation.
> >
> > Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
> > ("trace: move setting of group name into Makefiles")
> > Launchpad: https://bugs.launchpad.net/bugs/1844814
>
> Sorry I didn't noticed that earlier, but on https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
> we recommend using the 'Buglink' tag.
> Not sure it's worth resending another pull request...
Sure, it hasn't been merged yet so I can send a v2.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL 0/2] Tracing patches
2019-10-14 8:57 [PULL 0/2] Tracing patches Stefan Hajnoczi
2019-10-14 8:57 ` [PULL 1/2] trace: add --group=all to tracing.txt Stefan Hajnoczi
2019-10-14 8:57 ` [PULL 2/2] trace: avoid "is" with a literal Python 3.8 warnings Stefan Hajnoczi
@ 2019-10-15 12:24 ` Peter Maydell
2019-10-15 15:38 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2019-10-15 12:24 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Qemu-block, Jason Wang, QEMU Developers, Paolo Bonzini
On Mon, 14 Oct 2019 at 09:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to a1f4fc951a277c49a25418cafb028ec5529707fa:
>
> trace: avoid "is" with a literal Python 3.8 warnings (2019-10-14 09:54:46 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (2):
> trace: add --group=all to tracing.txt
> trace: avoid "is" with a literal Python 3.8 warnings
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL 0/2] Tracing patches
2019-10-15 12:24 ` [PULL 0/2] Tracing patches Peter Maydell
@ 2019-10-15 15:38 ` Philippe Mathieu-Daudé
2019-10-15 15:42 ` Peter Maydell
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-15 15:38 UTC (permalink / raw)
To: Peter Maydell, Stefan Hajnoczi
Cc: Fam Zheng, Paolo Bonzini, Jason Wang, QEMU Developers, Qemu-block
On 10/15/19 2:24 PM, Peter Maydell wrote:
> On Mon, 14 Oct 2019 at 09:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>
>> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
>>
>> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
>>
>> are available in the Git repository at:
>>
>> https://github.com/stefanha/qemu.git tags/tracing-pull-request
>>
>> for you to fetch changes up to a1f4fc951a277c49a25418cafb028ec5529707fa:
>>
>> trace: avoid "is" with a literal Python 3.8 warnings (2019-10-14 09:54:46 +0100)
>>
>> ----------------------------------------------------------------
>> Pull request
>>
>> ----------------------------------------------------------------
>>
>> Stefan Hajnoczi (2):
>> trace: add --group=all to tracing.txt
>> trace: avoid "is" with a literal Python 3.8 warnings
>>
>
>
> Applied, thanks.
Buh, v2 missed :(
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PULL 0/2] Tracing patches
2019-10-15 15:38 ` Philippe Mathieu-Daudé
@ 2019-10-15 15:42 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2019-10-15 15:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Qemu-block, Jason Wang, QEMU Developers,
Stefan Hajnoczi, Paolo Bonzini
On Tue, 15 Oct 2019 at 16:38, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 10/15/19 2:24 PM, Peter Maydell wrote:
> > On Mon, 14 Oct 2019 at 09:57, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >>
> >> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
> >>
> >> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
> >>
> >> are available in the Git repository at:
> >>
> >> https://github.com/stefanha/qemu.git tags/tracing-pull-request
> >>
> >> for you to fetch changes up to a1f4fc951a277c49a25418cafb028ec5529707fa:
> >>
> >> trace: avoid "is" with a literal Python 3.8 warnings (2019-10-14 09:54:46 +0100)
> >>
> >> ----------------------------------------------------------------
> >> Pull request
> >>
> >> ----------------------------------------------------------------
> >>
> >> Stefan Hajnoczi (2):
> >> trace: add --group=all to tracing.txt
> >> trace: avoid "is" with a literal Python 3.8 warnings
> >>
> >
> >
> > Applied, thanks.
>
> Buh, v2 missed :(
Oops. I don't necessarily notice updated pullreq versions unless
somebody follows up to the v1 coverletter to say the pull is out of date.
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-10-15 15:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 8:57 [PULL 0/2] Tracing patches Stefan Hajnoczi
2019-10-14 8:57 ` [PULL 1/2] trace: add --group=all to tracing.txt Stefan Hajnoczi
2019-10-14 9:08 ` Philippe Mathieu-Daudé
2019-10-15 8:45 ` Stefan Hajnoczi
2019-10-14 8:57 ` [PULL 2/2] trace: avoid "is" with a literal Python 3.8 warnings Stefan Hajnoczi
2019-10-15 12:24 ` [PULL 0/2] Tracing patches Peter Maydell
2019-10-15 15:38 ` Philippe Mathieu-Daudé
2019-10-15 15:42 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).