From: Igor Mammedov <imammedo@redhat.com>
To: Tao Xu <tao3.xu@intel.com>
Cc: lvivier@redhat.com, thuth@redhat.com, ehabkost@redhat.com,
mst@redhat.com, qemu-devel@nongnu.org, jingqi.liu@intel.com,
fan.du@intel.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com,
jonathan.cameron@huawei.com
Subject: Re: [PATCH v15 07/12] numa: Calculate hmat latency and bandwidth entry list
Date: Fri, 8 Nov 2019 13:12:10 +0100 [thread overview]
Message-ID: <20191108131210.64096a99@redhat.com> (raw)
In-Reply-To: <20191107074511.14304-8-tao3.xu@intel.com>
On Thu, 7 Nov 2019 15:45:06 +0800
Tao Xu <tao3.xu@intel.com> wrote:
> Compress HMAT latency and bandwidth raw data into uint16_t data,
> which can be stored in HMAT table.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Tao Xu <tao3.xu@intel.com>
> ---
>
> No changes in v15.
>
> Changes in v14:
> - Convert latency from ns to ps, because ACPI 6.3 HMAT table use
> ps as minimum unit
> ---
> hw/core/numa.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 58 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/numa.c b/hw/core/numa.c
> index f391760c20..523dd80822 100644
> --- a/hw/core/numa.c
> +++ b/hw/core/numa.c
> @@ -483,6 +483,47 @@ static void complete_init_numa_distance(MachineState *ms)
> }
> }
>
> +static void calculate_hmat_entry_list(HMAT_LB_Info *hmat_lb, int num_nodes)
I'd call it verify_hmat_entry_list()
and I'd only do checks here without post-processing data
into something else, provided there is checks that requires
all hmat-lb option parsed first.
> +{
> + int i, index;
> + uint16_t *entry_list;
> + uint64_t base;
> + GArray *lb_data_list;
> + HMAT_LB_Data *lb_data;
> +
> + if (hmat_lb->data_type <= HMAT_LB_DATA_WRITE_LATENCY) {
> + base = hmat_lb->base_latency;
> + lb_data_list = hmat_lb->latency;
> + } else {
> + base = hmat_lb->base_bandwidth;
> + lb_data_list = hmat_lb->bandwidth;
> + }
> +
> + entry_list = g_malloc0(lb_data_list->len * sizeof(uint16_t));
> + for (i = 0; i < lb_data_list->len; i++) {
> + lb_data = &g_array_index(lb_data_list, HMAT_LB_Data, i);
> + index = lb_data->initiator * num_nodes + lb_data->target;
> + if (entry_list[index]) {
> + error_report("Duplicate configuration of the latency for "
> + "initiator=%d and target=%d.", lb_data->initiator,
> + lb_data->target);
Is it possible to detect duplicate during hamt-lb option parsing?
> + exit(1);
> + }
> + entry_list[index] = (uint16_t)(lb_data->rawdata / base);
> + }
> + if (hmat_lb->data_type <= HMAT_LB_DATA_WRITE_LATENCY) {
> + /* Convert latency base from nanoseconds to picosecond */
> + hmat_lb->base_latency = base * 1000;
> + hmat_lb->entry_latency = entry_list;
> + } else {
> + /* Convert bandwidth base from Byte to Megabyte */
> + hmat_lb->base_bandwidth = base / MiB;
> + hmat_lb->entry_bandwidth = entry_list;
> + }
I suggest to move this hunk to 10/12 and drop entry_foo fields
as build_hmat_lb() can walk over lb_data_list and normalize values
put in ACPI table on its own.
In generic numa code is to check that user provided values won't
(under|over-flow) ACPI table values once dived/multiplied,
but leave actual data packing into table to ACPI code.
> +}
> +
> void numa_legacy_auto_assign_ram(MachineClass *mc, NodeInfo *nodes,
> int nb_nodes, ram_addr_t size)
> {
> @@ -521,9 +562,10 @@ void numa_default_auto_assign_ram(MachineClass *mc, NodeInfo *nodes,
>
> void numa_complete_configuration(MachineState *ms)
> {
> - int i;
> + int i, hierarchy, type;
> MachineClass *mc = MACHINE_GET_CLASS(ms);
> NodeInfo *numa_info = ms->numa_state->nodes;
> + HMAT_LB_Info *numa_hmat_lb;
>
> /*
> * If memory hotplug is enabled (slots > 0) but without '-numa'
> @@ -620,6 +662,21 @@ void numa_complete_configuration(MachineState *ms)
> /* Validation succeeded, now fill in any missing distances. */
> complete_init_numa_distance(ms);
> }
> +
> + if (ms->numa_state->hmat_enabled) {
> + for (hierarchy = HMAT_LB_MEM_MEMORY;
> + hierarchy <= HMAT_LB_MEM_CACHE_3RD_LEVEL; hierarchy++) {
> + for (type = HMAT_LB_DATA_ACCESS_LATENCY;
> + type <= HMAT_LB_DATA_WRITE_BANDWIDTH; type++) {
> + numa_hmat_lb = ms->numa_state->hmat_lb[hierarchy][type];
> +
> + if (numa_hmat_lb) {
> + calculate_hmat_entry_list(numa_hmat_lb,
> + ms->numa_state->num_nodes);
> + }
> + }
> + }
> + }
> }
> }
>
next prev parent reply other threads:[~2019-11-08 12:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 7:44 [PATCH v15 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT) Tao Xu
2019-11-07 7:45 ` [PATCH v15 01/12] util/cutils: refactor do_strtosz() to support suffixes list Tao Xu
2019-11-07 17:52 ` Eduardo Habkost
2019-11-07 7:45 ` [PATCH v15 02/12] util/cutils: Add qemu_strtotime_ns() Tao Xu
2019-11-07 17:55 ` Eduardo Habkost
2019-11-07 7:45 ` [PATCH v15 03/12] qapi: Add builtin type time Tao Xu
2019-11-07 7:45 ` [PATCH v15 04/12] tests: Add test for QAPI " Tao Xu
2019-11-07 7:45 ` [PATCH v15 05/12] numa: Extend CLI to provide initiator information for numa nodes Tao Xu
2019-11-07 7:45 ` [PATCH v15 06/12] numa: Extend CLI to provide memory latency and bandwidth information Tao Xu
2019-11-08 11:42 ` Igor Mammedov
2019-11-07 7:45 ` [PATCH v15 07/12] numa: Calculate hmat latency and bandwidth entry list Tao Xu
2019-11-08 12:12 ` Igor Mammedov [this message]
2019-11-07 7:45 ` [PATCH v15 08/12] numa: Extend CLI to provide memory side cache information Tao Xu
2019-11-08 13:34 ` Igor Mammedov
2019-11-07 7:45 ` [PATCH v15 09/12] hmat acpi: Build Memory Proximity Domain Attributes Structure(s) Tao Xu
2019-11-08 13:44 ` Igor Mammedov
2019-11-11 1:21 ` Tao Xu
2019-11-07 7:45 ` [PATCH v15 10/12] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s) Tao Xu
2019-11-08 14:11 ` Igor Mammedov
2019-11-07 7:45 ` [PATCH v15 11/12] hmat acpi: Build Memory Side Cache " Tao Xu
2019-11-08 14:39 ` Igor Mammedov
2019-11-07 7:45 ` [PATCH v15 12/12] tests/bios-tables-test: add test cases for ACPI HMAT Tao Xu
2019-11-08 14:51 ` Igor Mammedov
2019-11-07 9:03 ` [PATCH v15 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT) Michael S. Tsirkin
2019-11-08 0:57 ` Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108131210.64096a99@redhat.com \
--to=imammedo@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fan.du@intel.com \
--cc=jingqi.liu@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tao3.xu@intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).