* [PULL 0/1] Block patches
@ 2020-01-14 9:30 Stefan Hajnoczi
2020-01-14 9:30 ` [PULL 1/1] linux-aio: increasing MAX_EVENTS to a larger hardcoded value Stefan Hajnoczi
2020-01-14 16:00 ` [PULL 0/1] Block patches Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2020-01-14 9:30 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi, qemu-block, Max Reitz
The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 2558cb8dd4150512bc8ae6d505cdcd10d0cc46bb:
linux-aio: increasing MAX_EVENTS to a larger hardcoded value (2020-01-13 16:41:45 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Wangyong (1):
linux-aio: increasing MAX_EVENTS to a larger hardcoded value
block/linux-aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PULL 1/1] linux-aio: increasing MAX_EVENTS to a larger hardcoded value
2020-01-14 9:30 [PULL 0/1] Block patches Stefan Hajnoczi
@ 2020-01-14 9:30 ` Stefan Hajnoczi
2020-01-14 16:00 ` [PULL 0/1] Block patches Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2020-01-14 9:30 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, qemu-block, Max Reitz,
Stefan Hajnoczi, Wangyong
From: Wangyong <wang.yongD@h3c.com>
Since commit 6040aedddb5f474a9c2304b6a432a652d82b3d3c "virtio-blk:
make queue size configurable",if the user set the queue size to
more than 128 ,it will not take effect. That's because linux aio's
maximum outstanding requests at a time is always less than or equal
to 128.
This patch simply increase MAX_EVENTS to a larger hardcoded value of
1024 as a shortterm fix.
Signed-off-by: wangyong <wang.yongD@h3c.com>
Message-id: faa5781afd354a96a0be152b288f636f@h3c.com
Message-Id: <faa5781afd354a96a0be152b288f636f@h3c.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/linux-aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/linux-aio.c b/block/linux-aio.c
index c7eca9a256..91204a25a2 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -26,7 +26,7 @@
* than this we will get EAGAIN from io_submit which is communicated to
* the guest as an I/O error.
*/
-#define MAX_EVENTS 128
+#define MAX_EVENTS 1024
struct qemu_laiocb {
Coroutine *co;
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PULL 0/1] Block patches
2020-01-14 9:30 [PULL 0/1] Block patches Stefan Hajnoczi
2020-01-14 9:30 ` [PULL 1/1] linux-aio: increasing MAX_EVENTS to a larger hardcoded value Stefan Hajnoczi
@ 2020-01-14 16:00 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-01-14 16:00 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, QEMU Developers, Qemu-block, Max Reitz
On Tue, 14 Jan 2020 at 09:31, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 2558cb8dd4150512bc8ae6d505cdcd10d0cc46bb:
>
> linux-aio: increasing MAX_EVENTS to a larger hardcoded value (2020-01-13 16:41:45 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Wangyong (1):
> linux-aio: increasing MAX_EVENTS to a larger hardcoded value
>
> block/linux-aio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-14 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 9:30 [PULL 0/1] Block patches Stefan Hajnoczi
2020-01-14 9:30 ` [PULL 1/1] linux-aio: increasing MAX_EVENTS to a larger hardcoded value Stefan Hajnoczi
2020-01-14 16:00 ` [PULL 0/1] Block patches Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).