From: "Ján Tomko" <jtomko@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment
Date: Sun, 16 Feb 2020 22:12:35 +0100 [thread overview]
Message-ID: <20200216211235.GA745061@lpt> (raw)
In-Reply-To: <20200215161557.4077-2-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Sat, Feb 15, 2020 at 05:15:55PM +0100, Philippe Mathieu-Daudé wrote:
>Fix warning reported by Clang static code analyzer:
>
> CC block/qcow2-bitmap.o
> block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read
> ret = -EINVAL;
> ^ ~~~~~~~
>
>Reported-by: Clang Static Analyzer
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
> block/qcow2-bitmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Unused since its introduction in 88ddffae8fc1e30cc907c2dbb989b7eba9e62319
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-16 21:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 16:15 [PATCH 0/3] hw: Remove unneeded variable assignment Philippe Mathieu-Daudé
2020-02-15 16:15 ` [PATCH 1/3] block/qcow2-bitmap: " Philippe Mathieu-Daudé
2020-02-16 2:11 ` Richard Henderson
2020-02-16 21:12 ` Ján Tomko [this message]
2020-02-17 8:24 ` Vladimir Sementsov-Ogievskiy
2020-02-17 11:02 ` Kevin Wolf
2020-02-15 16:15 ` [PATCH 2/3] hw/display/qxl: " Philippe Mathieu-Daudé
2020-02-16 2:13 ` Richard Henderson
2020-02-18 19:15 ` Laurent Vivier
2020-02-15 16:15 ` [PATCH 3/3] hw/block/pflash_cfi02: " Philippe Mathieu-Daudé
2020-02-16 2:14 ` Richard Henderson
2020-02-18 19:16 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216211235.GA745061@lpt \
--to=jtomko@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).