From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Max Reitz <mreitz@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment
Date: Mon, 17 Feb 2020 11:24:43 +0300 [thread overview]
Message-ID: <3cd0f14c-38aa-cb6e-fd5b-ac3a35aaade0@virtuozzo.com> (raw)
In-Reply-To: <20200215161557.4077-2-philmd@redhat.com>
15.02.2020 19:15, Philippe Mathieu-Daudé wrote:
> Fix warning reported by Clang static code analyzer:
>
> CC block/qcow2-bitmap.o
> block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read
> ret = -EINVAL;
> ^ ~~~~~~~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> block/qcow2-bitmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
> index d41f5d049b..8cccc2c9f3 100644
> --- a/block/qcow2-bitmap.c
> +++ b/block/qcow2-bitmap.c
> @@ -647,7 +647,6 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState *bs, uint64_t offset,
> return bm_list;
>
> broken_dir:
> - ret = -EINVAL;
> error_setg(errp, "Broken bitmap directory");
>
> fail:
>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2020-02-17 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 16:15 [PATCH 0/3] hw: Remove unneeded variable assignment Philippe Mathieu-Daudé
2020-02-15 16:15 ` [PATCH 1/3] block/qcow2-bitmap: " Philippe Mathieu-Daudé
2020-02-16 2:11 ` Richard Henderson
2020-02-16 21:12 ` Ján Tomko
2020-02-17 8:24 ` Vladimir Sementsov-Ogievskiy [this message]
2020-02-17 11:02 ` Kevin Wolf
2020-02-15 16:15 ` [PATCH 2/3] hw/display/qxl: " Philippe Mathieu-Daudé
2020-02-16 2:13 ` Richard Henderson
2020-02-18 19:15 ` Laurent Vivier
2020-02-15 16:15 ` [PATCH 3/3] hw/block/pflash_cfi02: " Philippe Mathieu-Daudé
2020-02-16 2:14 ` Richard Henderson
2020-02-18 19:16 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd0f14c-38aa-cb6e-fd5b-ac3a35aaade0@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).