* [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions
@ 2020-08-04 0:28 Peter Collingbourne
2020-08-04 15:46 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Peter Collingbourne @ 2020-08-04 0:28 UTC (permalink / raw)
To: Richard Henderson, qemu-devel, qemu-arm; +Cc: Peter Collingbourne
These instructions use zero as the discriminator, not SP.
Signed-off-by: Peter Collingbourne <pcc@google.com>
---
v2:
- fixed commit message
target/arm/translate-a64.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 8c0764957c..c996ca1393 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -3429,9 +3429,11 @@ static void disas_ldst_pac(DisasContext *s, uint32_t insn,
if (s->pauth_active) {
if (use_key_a) {
- gen_helper_autda(dirty_addr, cpu_env, dirty_addr, cpu_X[31]);
+ gen_helper_autda(dirty_addr, cpu_env, dirty_addr,
+ new_tmp_a64_zero(s));
} else {
- gen_helper_autdb(dirty_addr, cpu_env, dirty_addr, cpu_X[31]);
+ gen_helper_autdb(dirty_addr, cpu_env, dirty_addr,
+ new_tmp_a64_zero(s));
}
}
--
2.28.0.163.g6104cc2f0b6-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions
2020-08-04 0:28 [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions Peter Collingbourne
@ 2020-08-04 15:46 ` Richard Henderson
2020-08-04 15:54 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2020-08-04 15:46 UTC (permalink / raw)
To: Peter Collingbourne, qemu-devel, qemu-arm
On 8/3/20 5:28 PM, Peter Collingbourne wrote:
> These instructions use zero as the discriminator, not SP.
>
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> ---
> v2:
> - fixed commit message
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions
2020-08-04 15:46 ` Richard Henderson
@ 2020-08-04 15:54 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-08-04 15:54 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-arm, Peter Collingbourne, QEMU Developers
On Tue, 4 Aug 2020 at 16:46, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 8/3/20 5:28 PM, Peter Collingbourne wrote:
> > These instructions use zero as the discriminator, not SP.
> >
> > Signed-off-by: Peter Collingbourne <pcc@google.com>
> > ---
> > v2:
> > - fixed commit message
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-04 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 0:28 [PATCH v2] target/arm: Fix decode of LDRA[AB] instructions Peter Collingbourne
2020-08-04 15:46 ` Richard Henderson
2020-08-04 15:54 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).