From: Leif Lindholm <leif@nuviainc.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] arm: bump amount of PMU counters to pass SBSA ACS
Date: Wed, 3 Mar 2021 17:48:49 +0000 [thread overview]
Message-ID: <20210303174849.GF1664@vanye> (raw)
In-Reply-To: <20210303151634.3421880-1-marcin.juszkiewicz@linaro.org>
On Wed, Mar 03, 2021 at 16:16:34 +0100, Marcin Juszkiewicz wrote:
> Arm BSA (Base System Architecture) specification says:
>
> B_PE_09: PEs must implement the FEAT_PMUv3p1 extension, and the base
> system must expose a minimum of four programmable PMU counters to the
> operating system.
>
> B_PE_21: The base system must expose a minimum of two programmable PMU
> counters to a hypervisor.
>
> It is then repeated in SBSA (Server Base System Architecture)
> specification in level 3 requirements:
>
> Each PE must implement a minimum of six programmable PMU counters.
>
> So let make QEMU provide those 6 PMU counters.
>
> SBSA-ACS says now:
>
> 12 : Check number of PMU counters : Result: PASS
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
It would be good if we could get 6.0 closer to SBSA compliance.
Would it be worth the effort to make this controllable per cpu model?
/
Leif
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 0e1a3b9421..02e25b5c22 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -38,7 +38,7 @@
> #endif
>
> #define ARM_CPU_FREQ 1000000000 /* FIXME: 1 GHz, should be configurable */
> -#define PMCR_NUM_COUNTERS 4 /* QEMU IMPDEF choice */
> +#define PMCR_NUM_COUNTERS 6 /* QEMU IMPDEF choice */
>
> #ifndef CONFIG_USER_ONLY
>
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-03-03 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 15:16 [PATCH] arm: bump amount of PMU counters to pass SBSA ACS Marcin Juszkiewicz
2021-03-03 17:48 ` Leif Lindholm [this message]
2021-03-03 18:06 ` Peter Maydell
2021-03-03 20:33 ` Marcin Juszkiewicz
2021-03-04 13:53 ` Leif Lindholm
2021-03-04 15:14 ` Peter Maydell
2021-03-04 15:25 ` Leif Lindholm
2021-03-11 17:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303174849.GF1664@vanye \
--to=leif@nuviainc.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).