From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [PATCH 2/2] i386: Disable 'kvm-asyncpf-int' feature for machine types <= 5.1
Date: Thu, 1 Apr 2021 17:19:57 +0200 [thread overview]
Message-ID: <20210401151957.408028-3-vkuznets@redhat.com> (raw)
In-Reply-To: <20210401151957.408028-1-vkuznets@redhat.com>
'kvm-asyncpf-int' was implemented in QEMU-5.2 so older machine types
should have it disabled to make migration to an older QEMU which does not
support this feature possible.
The issue went unnoticed probably because we also forgot to add
'kvm-asyncpf-int' to 'kvm_default_props[]' so it was rarely enabled.
Fixes: db5daafab2 ("target/i386: support KVM_FEATURE_ASYNC_PF_INT")
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
hw/i386/pc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 8a84b25a031e..04d5f76bf133 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -103,6 +103,7 @@ const size_t pc_compat_5_2_len = G_N_ELEMENTS(pc_compat_5_2);
GlobalProperty pc_compat_5_1[] = {
{ "ICH9-LPC", "x-smi-cpu-hotplug", "off" },
+ { TYPE_X86_CPU, "kvm-asyncpf-int", "off" },
{ TYPE_X86_CPU, "kvm-msi-ext-dest-id", "off" },
};
const size_t pc_compat_5_1_len = G_N_ELEMENTS(pc_compat_5_1);
--
2.30.2
next prev parent reply other threads:[~2021-04-01 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:19 [PATCH 0/2] i386: Fix interrupt based Async PF enablement Vitaly Kuznetsov
2021-04-01 15:19 ` [PATCH 1/2] i386: Add 'kvm-asyncpf-int' to kvm_default_props array Vitaly Kuznetsov
2021-04-01 15:19 ` Vitaly Kuznetsov [this message]
2021-04-01 15:57 ` [PATCH 0/2] i386: Fix interrupt based Async PF enablement Paolo Bonzini
2021-04-06 11:42 ` Vitaly Kuznetsov
2021-04-08 12:46 ` Paolo Bonzini
2021-04-15 19:14 ` Dr. David Alan Gilbert
2021-04-20 17:35 ` Eduardo Habkost
2021-04-21 8:38 ` Vitaly Kuznetsov
2021-04-21 8:50 ` Daniel P. Berrangé
2021-04-21 9:23 ` Dr. David Alan Gilbert
2021-04-21 9:29 ` Vitaly Kuznetsov
2021-04-21 9:34 ` Dr. David Alan Gilbert
2021-04-21 9:37 ` Daniel P. Berrangé
2021-04-21 9:48 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401151957.408028-3-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).