From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 0/2] i386: Fix interrupt based Async PF enablement
Date: Thu, 1 Apr 2021 17:57:52 +0200 [thread overview]
Message-ID: <ea3fc380-332f-b9e5-aa31-3540916cfc33@redhat.com> (raw)
In-Reply-To: <20210401151957.408028-1-vkuznets@redhat.com>
On 01/04/21 17:19, Vitaly Kuznetsov wrote:
> I noticed two issues with 'kvm-asyncpf-int' enablement:
> 1) We forgot to add to to kvm_default_props[] so it doesn't get enabled
> automatically (unless '-cpu host' is used or the feature is enabled
> manually on the command line)
> 2) We forgot to disable it for older machine types to preserve migration.
> This went unnoticed because of 1) I believe.
>
> Vitaly Kuznetsov (2):
> i386: Add 'kvm-asyncpf-int' to kvm_default_props array
> i386: Disable 'kvm-asyncpf-int' feature for machine types <= 5.1
>
> hw/i386/pc.c | 1 +
> target/i386/cpu.c | 1 +
> 2 files changed, 2 insertions(+)
>
Wasn't this intentional to avoid requiring a new kernel version?
Paolo
next prev parent reply other threads:[~2021-04-01 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:19 [PATCH 0/2] i386: Fix interrupt based Async PF enablement Vitaly Kuznetsov
2021-04-01 15:19 ` [PATCH 1/2] i386: Add 'kvm-asyncpf-int' to kvm_default_props array Vitaly Kuznetsov
2021-04-01 15:19 ` [PATCH 2/2] i386: Disable 'kvm-asyncpf-int' feature for machine types <= 5.1 Vitaly Kuznetsov
2021-04-01 15:57 ` Paolo Bonzini [this message]
2021-04-06 11:42 ` [PATCH 0/2] i386: Fix interrupt based Async PF enablement Vitaly Kuznetsov
2021-04-08 12:46 ` Paolo Bonzini
2021-04-15 19:14 ` Dr. David Alan Gilbert
2021-04-20 17:35 ` Eduardo Habkost
2021-04-21 8:38 ` Vitaly Kuznetsov
2021-04-21 8:50 ` Daniel P. Berrangé
2021-04-21 9:23 ` Dr. David Alan Gilbert
2021-04-21 9:29 ` Vitaly Kuznetsov
2021-04-21 9:34 ` Dr. David Alan Gilbert
2021-04-21 9:37 ` Daniel P. Berrangé
2021-04-21 9:48 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3fc380-332f-b9e5-aa31-3540916cfc33@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).