From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH v9 15/20] target/riscv/cpu.c: introduce cpu_cfg_ext_auto_update()
Date: Mon, 4 Sep 2023 11:16:46 +0200 [thread overview]
Message-ID: <20230904-4d9d67000cb284c362f8d06f@orel> (raw)
In-Reply-To: <20230901194627.1214811-16-dbarboza@ventanamicro.com>
On Fri, Sep 01, 2023 at 04:46:21PM -0300, Daniel Henrique Barboza wrote:
> During realize() time we're activating a lot of extensions based on some
> criteria, e.g.:
>
> if (cpu->cfg.ext_zk) {
> cpu->cfg.ext_zkn = true;
> cpu->cfg.ext_zkr = true;
> cpu->cfg.ext_zkt = true;
> }
>
> This practice resulted in at least one case where we ended up enabling
> something we shouldn't: RVC enabling zca/zcd/zcf when using a CPU that
> has priv_spec older than 1.12.0.
>
> We're also not considering user choice. There's no way of doing it now
> but this is about to change in the next few patches.
>
> cpu_cfg_ext_auto_update() will check for priv version mismatches before
> enabling extensions. If we have a mismatch between the current priv
> version and the extension we want to enable, do not enable it. In the
> near future, this same function will also consider user choice when
> deciding if we're going to enable/disable an extension or not.
>
> For now let's use it to handle zca/zcd/zcf enablement if RVC is enabled.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> target/riscv/cpu.c | 43 ++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 40 insertions(+), 3 deletions(-)
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
next prev parent reply other threads:[~2023-09-04 9:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 19:46 [PATCH v9 00/20] riscv: 'max' CPU, detect user choice in TCG Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 01/20] target/riscv/cpu.c: split CPU options from riscv_cpu_extensions[] Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 02/20] target/riscv/cpu.c: skip 'bool' check when filtering KVM props Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 03/20] target/riscv/cpu.c: split kvm prop handling to its own helper Daniel Henrique Barboza
2023-09-11 13:32 ` Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 04/20] target/riscv: add DEFINE_PROP_END_OF_LIST() to riscv_cpu_options[] Daniel Henrique Barboza
2023-09-04 1:48 ` Alistair Francis
2023-09-04 7:55 ` Philippe Mathieu-Daudé
2023-09-01 19:46 ` [PATCH v9 05/20] target/riscv/cpu.c: split non-ratified exts from riscv_cpu_extensions[] Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 06/20] target/riscv/cpu.c: split vendor " Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 07/20] target/riscv/cpu.c: add riscv_cpu_add_qdev_prop_array() Daniel Henrique Barboza
2023-09-04 1:51 ` Alistair Francis
2023-09-04 7:59 ` Philippe Mathieu-Daudé
2023-09-01 19:46 ` [PATCH v9 08/20] target/riscv/cpu.c: add riscv_cpu_add_kvm_unavail_prop_array() Daniel Henrique Barboza
2023-09-04 2:15 ` Alistair Francis
2023-09-01 19:46 ` [PATCH v9 09/20] target/riscv/cpu.c: limit cfg->vext_spec log message Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 10/20] target/riscv: add 'max' CPU type Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 11/20] avocado, risc-v: add tuxboot tests for 'max' CPU Daniel Henrique Barboza
2023-09-04 8:22 ` Philippe Mathieu-Daudé
2023-09-07 3:47 ` Alistair Francis
2023-09-01 19:46 ` [PATCH v9 12/20] target/riscv: deprecate the 'any' CPU type Daniel Henrique Barboza
2023-09-04 8:23 ` Philippe Mathieu-Daudé
2023-09-01 19:46 ` [PATCH v9 13/20] target/riscv/cpu.c: use offset in isa_ext_is_enabled/update_enabled Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 14/20] target/riscv: make CPUCFG() macro public Daniel Henrique Barboza
2023-09-04 8:04 ` Philippe Mathieu-Daudé
2023-09-01 19:46 ` [PATCH v9 15/20] target/riscv/cpu.c: introduce cpu_cfg_ext_auto_update() Daniel Henrique Barboza
2023-09-04 9:16 ` Andrew Jones [this message]
2023-09-07 4:06 ` Alistair Francis
2023-09-01 19:46 ` [PATCH v9 16/20] target/riscv/cpu.c: use cpu_cfg_ext_auto_update() during realize() Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 17/20] target/riscv/cpu.c: introduce RISCVCPUMultiExtConfig Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 18/20] target/riscv: use isa_ext_update_enabled() in init_max_cpu_extensions() Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 19/20] target/riscv/cpu.c: honor user choice in cpu_cfg_ext_auto_update() Daniel Henrique Barboza
2023-09-01 19:46 ` [PATCH v9 20/20] target/riscv/cpu.c: consider user option with RVG Daniel Henrique Barboza
2023-09-04 9:18 ` Andrew Jones
2023-09-07 4:13 ` [PATCH v9 00/20] riscv: 'max' CPU, detect user choice in TCG Alistair Francis
2023-09-11 2:34 ` Alistair Francis
2023-09-11 9:10 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904-4d9d67000cb284c362f8d06f@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).