* [PATCH] target/m68k: Allow movec only on 68010+
@ 2020-01-14 20:13 BALATON Zoltan
2020-01-14 20:50 ` Laurent Vivier
2020-05-01 13:11 ` BALATON Zoltan
0 siblings, 2 replies; 6+ messages in thread
From: BALATON Zoltan @ 2020-01-14 20:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
The movec opcode does not exist on 68000 and should raise an
exception. Fix the feature mask to only allow movec on newer 68k CPUs.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
target/m68k/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index fcdb7bc8e4..f19da064c8 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -5988,7 +5988,7 @@ void register_m68k_insns (CPUM68KState *env)
BASE(stop, 4e72, ffff);
BASE(rte, 4e73, ffff);
INSN(cf_movec, 4e7b, ffff, CF_ISA_A);
- INSN(m68k_movec, 4e7a, fffe, M68000);
+ INSN(m68k_movec, 4e7a, fffe, FPU);
#endif
BASE(nop, 4e71, ffff);
INSN(rtd, 4e74, ffff, RTD);
--
2.13.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Allow movec only on 68010+
2020-01-14 20:13 [PATCH] target/m68k: Allow movec only on 68010+ BALATON Zoltan
@ 2020-01-14 20:50 ` Laurent Vivier
2020-05-01 13:11 ` BALATON Zoltan
1 sibling, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2020-01-14 20:50 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, Lucien Murray-Pitts
Le 14/01/2020 à 21:13, BALATON Zoltan a écrit :
> The movec opcode does not exist on 68000 and should raise an
> exception. Fix the feature mask to only allow movec on newer 68k CPUs.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> target/m68k/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index fcdb7bc8e4..f19da064c8 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -5988,7 +5988,7 @@ void register_m68k_insns (CPUM68KState *env)
> BASE(stop, 4e72, ffff);
> BASE(rte, 4e73, ffff);
> INSN(cf_movec, 4e7b, ffff, CF_ISA_A);
> - INSN(m68k_movec, 4e7a, fffe, M68000);
> + INSN(m68k_movec, 4e7a, fffe, FPU);
> #endif
> BASE(nop, 4e71, ffff);
> INSN(rtd, 4e74, ffff, RTD);
>
Good point. But as movec is not related to FPU I don't think this is the
good flag to use.
Lucien has sent a patch to fix this issue last year:
[5/6] MOVEC insn. doesnt generate exception if wrong CR is accessed
https://patchwork.kernel.org/patch/10997467/
it needs a rework (M680x0 feature flags are now specific to each CPU, so
the table cannot be set to the older one, 68010, and 68060 is missing)
but I think it's a better approach.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Allow movec only on 68010+
2020-01-14 20:13 [PATCH] target/m68k: Allow movec only on 68010+ BALATON Zoltan
2020-01-14 20:50 ` Laurent Vivier
@ 2020-05-01 13:11 ` BALATON Zoltan
2020-05-01 14:02 ` Laurent Vivier
1 sibling, 1 reply; 6+ messages in thread
From: BALATON Zoltan @ 2020-05-01 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
Ping?
On Tue, 14 Jan 2020, BALATON Zoltan wrote:
> The movec opcode does not exist on 68000 and should raise an
> exception. Fix the feature mask to only allow movec on newer 68k CPUs.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> target/m68k/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index fcdb7bc8e4..f19da064c8 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -5988,7 +5988,7 @@ void register_m68k_insns (CPUM68KState *env)
> BASE(stop, 4e72, ffff);
> BASE(rte, 4e73, ffff);
> INSN(cf_movec, 4e7b, ffff, CF_ISA_A);
> - INSN(m68k_movec, 4e7a, fffe, M68000);
> + INSN(m68k_movec, 4e7a, fffe, FPU);
> #endif
> BASE(nop, 4e71, ffff);
> INSN(rtd, 4e74, ffff, RTD);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Allow movec only on 68010+
2020-05-01 13:11 ` BALATON Zoltan
@ 2020-05-01 14:02 ` Laurent Vivier
2020-05-02 1:38 ` BALATON Zoltan
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2020-05-01 14:02 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel
Le 01/05/2020 à 15:11, BALATON Zoltan a écrit :
> Ping?
I sent a comment:
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html
Thanks,
Laurent
>
> On Tue, 14 Jan 2020, BALATON Zoltan wrote:
>> The movec opcode does not exist on 68000 and should raise an
>> exception. Fix the feature mask to only allow movec on newer 68k CPUs.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> target/m68k/translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
>> index fcdb7bc8e4..f19da064c8 100644
>> --- a/target/m68k/translate.c
>> +++ b/target/m68k/translate.c
>> @@ -5988,7 +5988,7 @@ void register_m68k_insns (CPUM68KState *env)
>> BASE(stop, 4e72, ffff);
>> BASE(rte, 4e73, ffff);
>> INSN(cf_movec, 4e7b, ffff, CF_ISA_A);
>> - INSN(m68k_movec, 4e7a, fffe, M68000);
>> + INSN(m68k_movec, 4e7a, fffe, FPU);
>> #endif
>> BASE(nop, 4e71, ffff);
>> INSN(rtd, 4e74, ffff, RTD);
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Allow movec only on 68010+
2020-05-01 14:02 ` Laurent Vivier
@ 2020-05-02 1:38 ` BALATON Zoltan
2020-05-02 14:55 ` Laurent Vivier
0 siblings, 1 reply; 6+ messages in thread
From: BALATON Zoltan @ 2020-05-02 1:38 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
On Fri, 1 May 2020, Laurent Vivier wrote:
> Le 01/05/2020 à 15:11, BALATON Zoltan a écrit :
>> Ping?
>
> I sent a comment:
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html
Thanks, I've somehow missed that, did not show up in my inbox for some
reason. I wasn't sure about the FPU flag but did not find a better one
without adding new flag for 68010. Lucien's patch is indeed more complete
and should fix the same problem. So will that be merged then?
Regards,
BALATON Zoltan
> Thanks,
> Laurent
>
>>
>> On Tue, 14 Jan 2020, BALATON Zoltan wrote:
>>> The movec opcode does not exist on 68000 and should raise an
>>> exception. Fix the feature mask to only allow movec on newer 68k CPUs.
>>>
>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> ---
>>> target/m68k/translate.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
>>> index fcdb7bc8e4..f19da064c8 100644
>>> --- a/target/m68k/translate.c
>>> +++ b/target/m68k/translate.c
>>> @@ -5988,7 +5988,7 @@ void register_m68k_insns (CPUM68KState *env)
>>> BASE(stop, 4e72, ffff);
>>> BASE(rte, 4e73, ffff);
>>> INSN(cf_movec, 4e7b, ffff, CF_ISA_A);
>>> - INSN(m68k_movec, 4e7a, fffe, M68000);
>>> + INSN(m68k_movec, 4e7a, fffe, FPU);
>>> #endif
>>> BASE(nop, 4e71, ffff);
>>> INSN(rtd, 4e74, ffff, RTD);
>>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] target/m68k: Allow movec only on 68010+
2020-05-02 1:38 ` BALATON Zoltan
@ 2020-05-02 14:55 ` Laurent Vivier
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2020-05-02 14:55 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-devel, Lucien Murray-Pitts
Le 02/05/2020 à 03:38, BALATON Zoltan a écrit :
> On Fri, 1 May 2020, Laurent Vivier wrote:
>> Le 01/05/2020 à 15:11, BALATON Zoltan a écrit :
>>> Ping?
>>
>> I sent a comment:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html
>
> Thanks, I've somehow missed that, did not show up in my inbox for some
> reason. I wasn't sure about the FPU flag but did not find a better one
> without adding new flag for 68010. Lucien's patch is indeed more
> complete and should fix the same problem. So will that be merged then?
The series needs to be rebased but I'm not sure Lucien has the time for
that (cc: Lucien).
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-02 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 20:13 [PATCH] target/m68k: Allow movec only on 68010+ BALATON Zoltan
2020-01-14 20:50 ` Laurent Vivier
2020-05-01 13:11 ` BALATON Zoltan
2020-05-01 14:02 ` Laurent Vivier
2020-05-02 1:38 ` BALATON Zoltan
2020-05-02 14:55 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).