From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Lirong Yuan <yuanzi@google.com>, qemu-devel@nongnu.org
Cc: jkz@google.com, alex.bennee@linaro.org, scw@google.com
Subject: Re: [PATCH] gdbstub: add support to Xfer:auxv:read: packet
Date: Sat, 7 Mar 2020 01:17:53 +0100 [thread overview]
Message-ID: <289be6b2-8c38-987a-7c97-ed295df8744d@redhat.com> (raw)
In-Reply-To: <20200307000445.45265-1-yuanzi@google.com>
On 3/7/20 1:04 AM, Lirong Yuan wrote:
> This allows gdb to access the target’s auxiliary vector,
> which can be helpful for telling system libraries important details
> about the hardware, operating system, and process.
>
> Signed-off-by: Lirong Yuan <yuanzi@google.com>
> ---
> gdbstub.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 22a2d630cd..c2865ea873 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2105,6 +2105,12 @@ static void handle_query_supported(GdbCmdContext *gdb_ctx, void *user_ctx)
> pstrcat(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf),
> ";qXfer:features:read+");
> }
> +#ifdef CONFIG_USER_ONLY
> + if (gdb_ctx->s->c_cpu->opaque) {
> + pstrcat(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf),
> + ";qXfer:auxv:read+");
> + }
> +#endif
>
> if (gdb_ctx->num_params &&
> strstr(gdb_ctx->params[0].data, "multiprocess+")) {
> @@ -2166,6 +2172,42 @@ static void handle_query_xfer_features(GdbCmdContext *gdb_ctx, void *user_ctx)
> put_packet_binary(gdb_ctx->s, gdb_ctx->str_buf, len + 1, true);
> }
>
> +#ifdef CONFIG_USER_ONLY
> +static void handle_query_xfer_auxv(GdbCmdContext *gdb_ctx, void *user_ctx)
> +{
> + TaskState *ts;
> + unsigned long offset, len, saved_auxv, auxv_len;
> + const char *mem;
> +
> + if (gdb_ctx->num_params < 2) {
> + put_packet(gdb_ctx->s, "E22");
> + return;
> + }
> +
> + offset = gdb_ctx->params[0].val_ul;
> + len = gdb_ctx->params[1].val_ul;
> +
> + ts = gdb_ctx->s->c_cpu->opaque;
> + saved_auxv = ts->info->saved_auxv;
> + auxv_len = ts->info->auxv_len;
Maybe check we are in range first?
if (offset + len > auxv_len) {
put_packet(gdb_ctx->s, "E22");
return;
}
> + mem = (const char *)(saved_auxv + offset);
> +
> + if (len > (MAX_PACKET_LENGTH - 5) / 2) {
> + len = (MAX_PACKET_LENGTH - 5) / 2;
> + }
> +
> + if (len < auxv_len - offset) {
> + gdb_ctx->str_buf[0] = 'm';
> + len = memtox(gdb_ctx->str_buf + 1, mem, len);
> + } else {
> + gdb_ctx->str_buf[0] = 'l';
> + len = memtox(gdb_ctx->str_buf + 1, mem, auxv_len - offset);
> + }
> +
> + put_packet_binary(gdb_ctx->s, gdb_ctx->str_buf, len + 1, true);
> +}
> +#endif
> +
> static void handle_query_attached(GdbCmdContext *gdb_ctx, void *user_ctx)
> {
> put_packet(gdb_ctx->s, GDB_ATTACHED);
> @@ -2271,6 +2313,14 @@ static GdbCmdParseEntry gdb_gen_query_table[] = {
> .cmd_startswith = 1,
> .schema = "s:l,l0"
> },
> +#ifdef CONFIG_USER_ONLY
> + {
> + .handler = handle_query_xfer_auxv,
> + .cmd = "Xfer:auxv:read:",
> + .cmd_startswith = 1,
> + .schema = "l,l0"
> + },
> +#endif
> {
> .handler = handle_query_attached,
> .cmd = "Attached:",
>
next prev parent reply other threads:[~2020-03-07 0:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 0:04 [PATCH] gdbstub: add support to Xfer:auxv:read: packet Lirong Yuan
2020-03-07 0:17 ` Philippe Mathieu-Daudé [this message]
2020-03-07 1:00 Lirong Yuan
2020-03-07 1:30 ` no-reply
2020-03-18 23:26 ` Lirong Yuan
2020-03-20 9:17 ` Alex Bennée
2020-03-20 23:56 ` Lirong Yuan
2020-03-21 13:56 ` Alex Bennée
2020-03-30 17:32 ` Lirong Yuan
2020-03-30 19:47 ` Alex Bennée
2020-03-30 22:11 ` Lirong Yuan
2020-03-31 7:20 ` Alex Bennée
2020-07-21 17:50 ` Lirong Yuan
2020-07-21 19:50 ` Alex Bennée
2020-07-21 20:29 ` Lirong Yuan
2020-07-30 19:44 ` Lirong Yuan
2020-03-30 17:13 Lirong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289be6b2-8c38-987a-7c97-ed295df8744d@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=jkz@google.com \
--cc=qemu-devel@nongnu.org \
--cc=scw@google.com \
--cc=yuanzi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).