From: "Alex Bennée" <alex.bennee@linaro.org>
To: Lirong Yuan <yuanzi@google.com>
Cc: "Josh Kunz" <jkz@google.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Shu-Chun Weng" <scw@google.com>
Subject: Re: [PATCH] gdbstub: add support to Xfer:auxv:read: packet
Date: Sat, 21 Mar 2020 13:56:11 +0000 [thread overview]
Message-ID: <87d095u804.fsf@linaro.org> (raw)
In-Reply-To: <CADjx4CJJdQep+K3ibfhjin7Eo6uCEFGQ6R6yVC0OcNo8MsfvJw@mail.gmail.com>
Lirong Yuan <yuanzi@google.com> writes:
> On Fri, Mar 20, 2020 at 2:17 AM Alex Bennée <alex.bennee@linaro.org> wrote:
<snip>
>>
>> Sorry I missed this on my radar. There was a minor re-factor of gdbstub
>> that was just merged which will mean this patch needs a re-base to use
>> g_string_* functions to expand stings.
>>
>> Also we have some simple gdbstub tests now - could we come up with a
>> multiarch gdbstub test to verify this is working properly?
>>
<snip>
> For sure, I will re-base this patch to use g_string_* functions.
>
> Currently we are using qemu aarch64. I am not sure how to do this yet, but
> I could try to add something to
> https://github.com/qemu/qemu/tree/master/tests/tcg/aarch64/gdbstub
If the auxv support is appropriate to all linux-user targets you can
plumb it into the multiarch tests - you can even use the existing
binaries.
So you need:
- a stanza in the makefiles to launch the test (see
tests/tcg/aarch64/Makefile.target)
- a .py test script that manipulates gdbstub to check things are working
So something like:
.PHONY: gdbstub-foo-binary
run-gdbstub-foo-binary: foo-binary
$(call run-test, $@, $(GDB_SCRIPT) \
--gdb $(HAVE_GDB_BIN) \
--qemu $(QEMU) --qargs "$(QEMU_OPTS)" \
--bin $< --test $(MULTIARCH_SRC)/gdbstub/test-foo.py, \
"basic gdbstub FOO support")
>
> Does this sound good?
Hope that helps.
>
> Thanks!
> Lirong
--
Alex Bennée
next prev parent reply other threads:[~2020-03-21 13:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 1:00 [PATCH] gdbstub: add support to Xfer:auxv:read: packet Lirong Yuan
2020-03-07 1:30 ` no-reply
2020-03-18 23:26 ` Lirong Yuan
2020-03-20 9:17 ` Alex Bennée
2020-03-20 23:56 ` Lirong Yuan
2020-03-21 13:56 ` Alex Bennée [this message]
2020-03-30 17:32 ` Lirong Yuan
2020-03-30 19:47 ` Alex Bennée
2020-03-30 22:11 ` Lirong Yuan
2020-03-31 7:20 ` Alex Bennée
2020-07-21 17:50 ` Lirong Yuan
2020-07-21 19:50 ` Alex Bennée
2020-07-21 20:29 ` Lirong Yuan
2020-07-30 19:44 ` Lirong Yuan
-- strict thread matches above, loose matches on Subject: below --
2020-03-30 17:13 Lirong Yuan
2020-03-07 0:04 Lirong Yuan
2020-03-07 0:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d095u804.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jkz@google.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=scw@google.com \
--cc=yuanzi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).