From: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>, Andrew Jeffery <andrew@aj.id.au>,
Joel Stanley <joel@jms.id.au>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation
Date: Wed, 24 Mar 2021 21:15:31 -0300 [thread overview]
Message-ID: <2c679546-0f60-b8cb-cf85-29f2e897d877@linux.vnet.ibm.com> (raw)
In-Reply-To: <d3274402-58e2-c7ca-f808-7e2d51f29d89@kaod.org>
Hi Cedric,
On 3/24/2021 7:57 PM, Cédric Le Goater wrote:
> On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote:
>> Basically using camelCase for some variables...
> I don't think CamelCase applies to variables, only types.
Thanks, I think I mis-interpreted your comment on this.
Will re-factor the patches with that in mind, but let's see
if there are other comments first.
-Klaus
--
Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
next prev parent reply other threads:[~2021-03-25 0:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 22:38 [PATCH 0/3] aspeed: HACE hash Scatter-Gather support Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation Klaus Heinrich Kiwi
2021-03-24 22:57 ` Cédric Le Goater
2021-03-25 0:15 ` Klaus Heinrich Kiwi [this message]
2021-03-24 22:38 ` [PATCH 2/3] aspeed: Add Scater-Gather support for HACE Hash Klaus Heinrich Kiwi
2021-03-25 3:40 ` Joel Stanley
2021-03-26 16:47 ` Klaus Heinrich Kiwi
2021-03-25 7:55 ` Cédric Le Goater
2021-03-26 16:51 ` Klaus Heinrich Kiwi
2021-03-24 22:38 ` [PATCH 3/3] tests: Aspeed HACE Scatter-Gather tests Klaus Heinrich Kiwi
2021-03-25 2:18 ` Joel Stanley
2021-03-26 17:00 ` Klaus Heinrich Kiwi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c679546-0f60-b8cb-cf85-29f2e897d877@linux.vnet.ibm.com \
--to=klaus@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).