qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging
Date: Tue, 14 Jan 2020 09:28:42 +0100	[thread overview]
Message-ID: <316a4963-a65a-4396-ef72-32358f45a4e3@vivier.eu> (raw)
In-Reply-To: <20200114030138.260347-2-jkz@google.com>

Le 14/01/2020 à 04:01, Josh Kunz a écrit :
> This change introduces a new logging mask "LOG_USER", which is used for
> masking general user-mode logging. This change also switches all non-strace
> uses of `gemu_log' in linux-user/ to use `qemu_log_mask(LOG_USER, ...)'
> instead. This allows the user to easily log to a file, and to mask out
> these log messages if they desire.
> 
> Signed-off-by: Josh Kunz <jkz@google.com>
> ---
>  include/qemu/log.h        |  2 ++
>  linux-user/arm/cpu_loop.c |  5 ++--
>  linux-user/fd-trans.c     | 55 +++++++++++++++++++++++++--------------
>  linux-user/main.c         | 24 +++++++++++++++++
>  linux-user/syscall.c      | 30 ++++++++++++---------
>  linux-user/vm86.c         |  3 ++-
>  util/log.c                |  3 +++
>  7 files changed, 86 insertions(+), 36 deletions(-)

I think most of these log messages should use LOG_UNIMP, so no need for
a new flag.

Thanks,
Laurent



  reply	other threads:[~2020-01-14  8:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14  3:01 [PATCH 0/4] migration: Replace gemu_log with qemu_log Josh Kunz
2020-01-14  3:01 ` [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging Josh Kunz
2020-01-14  8:28   ` Laurent Vivier [this message]
2020-01-14  8:30   ` Laurent Vivier
2020-01-14 10:42   ` Alex Bennée
2020-01-17 19:28     ` Josh Kunz
2020-01-14  3:01 ` [PATCH 2/4] linux-user: Use `qemu_log' for strace Josh Kunz
2020-01-14  9:09   ` Laurent Vivier
2020-01-14 16:15     ` Paolo Bonzini
2020-01-17 19:28     ` Josh Kunz
2020-01-14 10:55   ` Alex Bennée
2020-01-17 19:28     ` Josh Kunz
2020-01-14  3:01 ` [PATCH 3/4] linux-user: remove gemu_log from the linux-user tree Josh Kunz
2020-01-14 10:56   ` Alex Bennée
2020-01-14  3:01 ` [PATCH 4/4] bsd-user: Replace gemu_log with qemu_log Josh Kunz
2020-01-14  3:06 ` [PATCH 0/4] migration: " Warner Losh
2020-01-16 23:13   ` Josh Kunz
2020-01-14 11:02 ` Alex Bennée
2020-01-16 23:12   ` Josh Kunz
2020-01-20 11:36     ` Alex Bennée
2020-02-04  2:55       ` Josh Kunz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=316a4963-a65a-4396-ef72-32358f45a4e3@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).