From: Josh Kunz <jkz@google.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
armbru@redhat.com
Subject: Re: [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging
Date: Fri, 17 Jan 2020 11:28:39 -0800 [thread overview]
Message-ID: <CADgy-2uAkXj5b5gh_mgUGKFBUJovmngG0s1OG+Fpqmhoawm97g@mail.gmail.com> (raw)
In-Reply-To: <87pnfmmi8c.fsf@linaro.org>
On Tue, Jan 14, 2020 at 2:43 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> As Laurent said I think LOG_UNIMP is perfectly fine for stuff we haven't
> done. I don't think any of the cases warrant LOG_GUEST_ERROR.
I've replaced `LOG_USER` with `LOG_UNIMP`. Didn't catch that mask at
first, LOG_UNIMP is indeed a better fit for most of these.
> I'm not sure want to bother with this. I know we like to avoid
> regression but isn't this all debug log stuff? If we must keep it can we
> invert the variable to save the initialisation.
I'm all for removing it. I agree that it would be pretty odd for
someone to depend on debug log output in this way. I've removed this
in v2. It is a backwards incompatibility though, so I'm happy to
re-add the fix if people want it.
> I mean we jumped through hoops to maintain backwards compatibility and
> then added new output? Also LOG_STRACE doesn't exist yet.
This is leftover debug statements. I've removed it.
> I'm not sure we shouldn't just be asserting this case above. The
> comments imply it is a bug on our part. The rest look like good cases
> for LOG_UNIMP.
Switched to an assert in v2.
next prev parent reply other threads:[~2020-01-17 19:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 3:01 [PATCH 0/4] migration: Replace gemu_log with qemu_log Josh Kunz
2020-01-14 3:01 ` [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging Josh Kunz
2020-01-14 8:28 ` Laurent Vivier
2020-01-14 8:30 ` Laurent Vivier
2020-01-14 10:42 ` Alex Bennée
2020-01-17 19:28 ` Josh Kunz [this message]
2020-01-14 3:01 ` [PATCH 2/4] linux-user: Use `qemu_log' for strace Josh Kunz
2020-01-14 9:09 ` Laurent Vivier
2020-01-14 16:15 ` Paolo Bonzini
2020-01-17 19:28 ` Josh Kunz
2020-01-14 10:55 ` Alex Bennée
2020-01-17 19:28 ` Josh Kunz
2020-01-14 3:01 ` [PATCH 3/4] linux-user: remove gemu_log from the linux-user tree Josh Kunz
2020-01-14 10:56 ` Alex Bennée
2020-01-14 3:01 ` [PATCH 4/4] bsd-user: Replace gemu_log with qemu_log Josh Kunz
2020-01-14 3:06 ` [PATCH 0/4] migration: " Warner Losh
2020-01-16 23:13 ` Josh Kunz
2020-01-14 11:02 ` Alex Bennée
2020-01-16 23:12 ` Josh Kunz
2020-01-20 11:36 ` Alex Bennée
2020-02-04 2:55 ` Josh Kunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADgy-2uAkXj5b5gh_mgUGKFBUJovmngG0s1OG+Fpqmhoawm97g@mail.gmail.com \
--to=jkz@google.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).