From: Richard Henderson <richard.henderson@linaro.org>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com,
bmeng@tinylab.org, liwei1518@gmail.com,
zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com,
max.chou@sifive.com
Subject: Re: [PATCH v5 4/7] target/riscv/translate.c: remove 'cpu_vstart' global
Date: Tue, 20 Feb 2024 16:41:37 -1000 [thread overview]
Message-ID: <47c3cb02-9a1c-4ac0-a815-3a3cdcaa9fab@linaro.org> (raw)
In-Reply-To: <20240221022252.252872-5-dbarboza@ventanamicro.com>
On 2/20/24 16:22, Daniel Henrique Barboza wrote:
> The global is unused after recent changes.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> target/riscv/translate.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Does this leave exactly one use of cpu_vl, in do_vsetvl()?
If so, it would be worth removing that too, replacing the single use with an explicit load
from env.
r~
next prev parent reply other threads:[~2024-02-21 2:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 2:22 [PATCH v5 0/7] riscv: set vstart_eq_zero on mark_vs_dirty Daniel Henrique Barboza
2024-02-21 2:22 ` [PATCH v5 1/7] trans_rvv.c.inc: mark_vs_dirty() before loads and stores Daniel Henrique Barboza
2024-02-21 2:22 ` [PATCH v5 2/7] trans_rvv.c.inc: remove 'is_store' bool from load/store fns Daniel Henrique Barboza
2024-02-21 8:57 ` Philippe Mathieu-Daudé
2024-02-21 2:22 ` [PATCH v5 3/7] target/riscv: remove 'over' brconds from vector trans Daniel Henrique Barboza
2024-02-21 2:22 ` [PATCH v5 4/7] target/riscv/translate.c: remove 'cpu_vstart' global Daniel Henrique Barboza
2024-02-21 2:41 ` Richard Henderson [this message]
2024-02-21 2:22 ` [PATCH v5 5/7] target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX() Daniel Henrique Barboza
2024-02-21 2:22 ` [PATCH v5 6/7] trans_rvv.c.inc: remove redundant mark_vs_dirty() calls Daniel Henrique Barboza
2024-02-21 2:22 ` [PATCH v5 7/7] target/riscv: Clear vstart_qe_zero flag Daniel Henrique Barboza
2024-02-21 21:24 ` [PATCH v5 0/7] riscv: set vstart_eq_zero on mark_vs_dirty Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c3cb02-9a1c-4ac0-a815-3a3cdcaa9fab@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=max.chou@sifive.com \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).