* [PATCH] qom/object: simplify type_initialize_interface()
@ 2020-05-12 18:25 Masahiro Yamada
2020-05-21 14:45 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2020-05-12 18:25 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini, Daniel P . Berrange, Eduardo Habkost
Cc: Masahiro Yamada
iface_impl->class is the same as new_iface. Make it more readable.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
qom/object.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 9d1a918e42..75c628591d 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -262,8 +262,7 @@ static void type_initialize_interface(TypeImpl *ti, TypeImpl *interface_type,
new_iface->concrete_class = ti->class;
new_iface->interface_type = interface_type;
- ti->class->interfaces = g_slist_append(ti->class->interfaces,
- iface_impl->class);
+ ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
}
static void object_property_free(gpointer data)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qom/object: simplify type_initialize_interface()
2020-05-12 18:25 [PATCH] qom/object: simplify type_initialize_interface() Masahiro Yamada
@ 2020-05-21 14:45 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-05-21 14:45 UTC (permalink / raw)
To: Masahiro Yamada, qemu-devel, Daniel P . Berrange, Eduardo Habkost
On 12/05/20 20:25, Masahiro Yamada wrote:
> iface_impl->class is the same as new_iface. Make it more readable.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> qom/object.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index 9d1a918e42..75c628591d 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -262,8 +262,7 @@ static void type_initialize_interface(TypeImpl *ti, TypeImpl *interface_type,
> new_iface->concrete_class = ti->class;
> new_iface->interface_type = interface_type;
>
> - ti->class->interfaces = g_slist_append(ti->class->interfaces,
> - iface_impl->class);
> + ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
> }
>
> static void object_property_free(gpointer data)
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-21 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 18:25 [PATCH] qom/object: simplify type_initialize_interface() Masahiro Yamada
2020-05-21 14:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).