* [PATCH] roms: Add a 'make help' target alias
@ 2019-09-20 17:11 Philippe Mathieu-Daudé
2019-09-20 17:13 ` Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-20 17:11 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, John Snow, Laszlo Ersek, Philippe Mathieu-Daudé
Various C projects provide a 'make help' target. Our root directory
does so. The roms/ directory lacks a such rule, but already displays
a help output when the default target is called.
Add a 'help' target aliased to the default one, to avoid:
$ make -C roms help
make: *** No rule to make target 'help'. Stop.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
roms/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/roms/Makefile b/roms/Makefile
index 6cf07d3b44..3ffd13cc7e 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
#
EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
-default:
+default help:
@echo "nothing is build by default"
@echo "available build targets:"
@echo " bios -- update bios.bin (seabios)"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] roms: Add a 'make help' target alias
2019-09-20 17:11 [PATCH] roms: Add a 'make help' target alias Philippe Mathieu-Daudé
@ 2019-09-20 17:13 ` Peter Maydell
2019-09-20 17:36 ` John Snow
2019-09-24 15:55 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-09-20 17:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Laszlo Ersek, John Snow, QEMU Developers
On Fri, 20 Sep 2019 at 18:12, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
>
> $ make -C roms help
> make: *** No rule to make target 'help'. Stop.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> roms/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
> #
> EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>
> -default:
> +default help:
> @echo "nothing is build by default"
If you felt like fixing a typo, there's one here: should
be "is built"...
> @echo "available build targets:"
> @echo " bios -- update bios.bin (seabios)"
> --
> 2.20.1
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] roms: Add a 'make help' target alias
2019-09-20 17:11 [PATCH] roms: Add a 'make help' target alias Philippe Mathieu-Daudé
2019-09-20 17:13 ` Peter Maydell
@ 2019-09-20 17:36 ` John Snow
2019-09-24 15:55 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: John Snow @ 2019-09-20 17:36 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Laszlo Ersek
On 9/20/19 1:11 PM, Philippe Mathieu-Daudé wrote:
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
>
> $ make -C roms help
> make: *** No rule to make target 'help'. Stop.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> roms/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
> #
> EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>
> -default:
> +default help:
> @echo "nothing is build by default"
> @echo "available build targets:"
> @echo " bios -- update bios.bin (seabios)"
>
Reviewed-by: John Snow <jsnow@redhat.com>
The typo can be fixed with a trivial patch or squashed into this fix,
the purity of such things doesn't matter to me.
--js
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] roms: Add a 'make help' target alias
2019-09-20 17:11 [PATCH] roms: Add a 'make help' target alias Philippe Mathieu-Daudé
2019-09-20 17:13 ` Peter Maydell
2019-09-20 17:36 ` John Snow
@ 2019-09-24 15:55 ` Laszlo Ersek
2 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2019-09-24 15:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, John Snow
On 09/20/19 19:11, Philippe Mathieu-Daudé wrote:
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
>
> $ make -C roms help
> make: *** No rule to make target 'help'. Stop.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> roms/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
> #
> EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>
> -default:
> +default help:
> @echo "nothing is build by default"
> @echo "available build targets:"
> @echo " bios -- update bios.bin (seabios)"
>
How about we just print: "help yourself"?
Just kidding. :P
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-24 16:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 17:11 [PATCH] roms: Add a 'make help' target alias Philippe Mathieu-Daudé
2019-09-20 17:13 ` Peter Maydell
2019-09-20 17:36 ` John Snow
2019-09-24 15:55 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).