qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
	alistair.francis@wdc.com,  bmeng@tinylab.org,
	liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
	 palmer@rivosinc.com, richard.henderson@linaro.org
Subject: Re: [PATCH v3 0/3] target/riscv: implement query-cpu-definitions
Date: Fri, 5 May 2023 11:59:34 +1000	[thread overview]
Message-ID: <CAKmqyKOUHKsK27=1PvQr-xM5vMvZ5hj_EzBeeXr-xQ3tdNhw1A@mail.gmail.com> (raw)
In-Reply-To: <6946d44f-8b24-de00-7efc-e35d48f62705@ventanamicro.com>

On Wed, May 3, 2023 at 7:51 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Alistair,
>
> Patch 2 has a typo right in the commit title:
>
> "target/riscv: add query-cpy-definitions support"
>
> it should be 'query-cpu-definitions'. Can you amend it in the tree? Or should
> I re-send?

I have fixed it in my tree, so no need to resend.

I did already send the PR though. I don't think it's worth re-sending
a v2 PR for the typo

Alistair

>
>
>
> Thanks,
>
>
> Daniel
>
>
>
> On 4/16/23 23:58, Alistair Francis wrote:
> > On Wed, Apr 12, 2023 at 4:36 AM Daniel Henrique Barboza
> > <dbarboza@ventanamicro.com> wrote:
> >>
> >> Hi,
> >>
> >> In this v3 I removed patches 3 and 4 of v2.
> >>
> >> Patch 3 now implements a new type that the generic CPUs (any, rv32,
> >> rv64, x-rv128) were converted to. This type will be used by
> >> query-cpu-definitions to determine if a given cpu is static or not based
> >> on its type. This approach was suggested by Richard Henderson in the v2
> >> review.
> >>
> >> Patches are based on top of Alistair's riscv-to-apply.next.
> >>
> >> Changes from v2:
> >> - old patches 3 and 4: removed
> >> - patch 3:
> >>    - add TYPE_RISCV_DYNAMIC_CPU
> >>    - use this type to set 'q_static' in riscv_cpu_add_definition()
> >> - v2 link: https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg01310.html
> >>
> >> Daniel Henrique Barboza (3):
> >>    target/riscv: add CPU QOM header
> >>    target/riscv: add query-cpy-definitions support
> >>    target/riscv: add TYPE_RISCV_DYNAMIC_CPU
> >
> > Thanks!
> >
> > Applied to riscv-to-apply.next
> >
> > Alistair
> >
> >>
> >>   qapi/machine-target.json      |  6 ++-
> >>   target/riscv/cpu-qom.h        | 70 +++++++++++++++++++++++++++++++++++
> >>   target/riscv/cpu.c            | 20 ++++++++--
> >>   target/riscv/cpu.h            | 46 +----------------------
> >>   target/riscv/meson.build      |  3 +-
> >>   target/riscv/riscv-qmp-cmds.c | 57 ++++++++++++++++++++++++++++
> >>   6 files changed, 150 insertions(+), 52 deletions(-)
> >>   create mode 100644 target/riscv/cpu-qom.h
> >>   create mode 100644 target/riscv/riscv-qmp-cmds.c
> >>
> >> --
> >> 2.39.2
> >>
> >>


      reply	other threads:[~2023-05-05  2:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 18:35 [PATCH v3 0/3] target/riscv: implement query-cpu-definitions Daniel Henrique Barboza
2023-04-11 18:35 ` [PATCH v3 1/3] target/riscv: add CPU QOM header Daniel Henrique Barboza
2023-04-17  2:55   ` Alistair Francis
2023-04-11 18:35 ` [PATCH v3 2/3] target/riscv: add query-cpy-definitions support Daniel Henrique Barboza
2023-04-17  2:56   ` Alistair Francis
2023-04-11 18:35 ` [PATCH v3 3/3] target/riscv: add TYPE_RISCV_DYNAMIC_CPU Daniel Henrique Barboza
2023-04-12 10:18   ` Richard Henderson
2023-04-17  2:57   ` Alistair Francis
2023-04-17  2:58 ` [PATCH v3 0/3] target/riscv: implement query-cpu-definitions Alistair Francis
2023-05-03  9:51   ` Daniel Henrique Barboza
2023-05-05  1:59     ` Alistair Francis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKOUHKsK27=1PvQr-xM5vMvZ5hj_EzBeeXr-xQ3tdNhw1A@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=bmeng@tinylab.org \
    --cc=dbarboza@ventanamicro.com \
    --cc=liweiwei@iscas.ac.cn \
    --cc=palmer@rivosinc.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).