* [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text
@ 2019-09-06 11:39 Thomas Huth
2019-09-09 16:41 ` John Snow
2019-09-10 10:56 ` Max Reitz
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2019-09-06 11:39 UTC (permalink / raw)
To: qemu-block, Max Reitz; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
When running "make check -j8" or something similar, the iotests are
running in parallel with the other tests. So when they are printing
out "Passed all xx tests" or a similar status message at the end,
it might not be quite clear that this message belongs to the iotests,
since the output might be mixed with the other tests. Thus change the
word "tests" here to "iotests" instead to avoid confusion.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/check | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index c24874ff4a..2f1cf72abc 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -694,12 +694,12 @@ END { if (NR > 0) {
if [ ! -z "$n_bad" -a $n_bad != 0 ]
then
echo "Failures:$bad"
- echo "Failed $n_bad of $try tests"
+ echo "Failed $n_bad of $try iotests"
echo "Failures:$bad" | fmt >>check.log
- echo "Failed $n_bad of $try tests" >>check.log
+ echo "Failed $n_bad of $try iotests" >>check.log
else
- echo "Passed all $try tests"
- echo "Passed all $try tests" >>check.log
+ echo "Passed all $try iotests"
+ echo "Passed all $try iotests" >>check.log
fi
needwrap=false
fi
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text
2019-09-06 11:39 [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text Thomas Huth
@ 2019-09-09 16:41 ` John Snow
2019-09-10 10:56 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2019-09-09 16:41 UTC (permalink / raw)
To: Thomas Huth, qemu-block, Max Reitz; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
On 9/6/19 7:39 AM, Thomas Huth wrote:
> When running "make check -j8" or something similar, the iotests are
> running in parallel with the other tests. So when they are printing
> out "Passed all xx tests" or a similar status message at the end,
> it might not be quite clear that this message belongs to the iotests,
> since the output might be mixed with the other tests. Thus change the
> word "tests" here to "iotests" instead to avoid confusion.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Yeah, why not? Being explicit is nice.
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/check | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index c24874ff4a..2f1cf72abc 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -694,12 +694,12 @@ END { if (NR > 0) {
> if [ ! -z "$n_bad" -a $n_bad != 0 ]
> then
> echo "Failures:$bad"
> - echo "Failed $n_bad of $try tests"
> + echo "Failed $n_bad of $try iotests"
> echo "Failures:$bad" | fmt >>check.log
> - echo "Failed $n_bad of $try tests" >>check.log
> + echo "Failed $n_bad of $try iotests" >>check.log
> else
> - echo "Passed all $try tests"
> - echo "Passed all $try tests" >>check.log
> + echo "Passed all $try iotests"
> + echo "Passed all $try iotests" >>check.log
> fi
> needwrap=false
> fi
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text
2019-09-06 11:39 [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text Thomas Huth
2019-09-09 16:41 ` John Snow
@ 2019-09-10 10:56 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2019-09-10 10:56 UTC (permalink / raw)
To: Thomas Huth, qemu-block; +Cc: Kevin Wolf, qemu-trivial, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 721 bytes --]
On 06.09.19 13:39, Thomas Huth wrote:
> When running "make check -j8" or something similar, the iotests are
> running in parallel with the other tests. So when they are printing
> out "Passed all xx tests" or a similar status message at the end,
> it might not be quite clear that this message belongs to the iotests,
> since the output might be mixed with the other tests. Thus change the
> word "tests" here to "iotests" instead to avoid confusion.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/check | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-10 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 11:39 [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text Thomas Huth
2019-09-09 16:41 ` John Snow
2019-09-10 10:56 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).