From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Peter Krempa <pkrempa@redhat.com>, John Snow <jsnow@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"libvir-list@redhat.com" <libvir-list@redhat.com>,
"armbru@redhat.com" <armbru@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters
Date: Thu, 29 Aug 2019 15:17:39 +0000 [thread overview]
Message-ID: <c3e0c5d2-4c2f-0565-140d-b16c3e4a87b8@virtuozzo.com> (raw)
In-Reply-To: <20190829144446.GL13714@angien.pipo.sk>
29.08.2019 17:44, Peter Krempa wrote:
> On Wed, Aug 28, 2019 at 13:48:10 -0400, John Snow wrote:
>> (Peter: search for "pkrempa" down below.)
>>
>> On 8/28/19 5:20 AM, Vladimir Sementsov-Ogievskiy wrote:
>
> [....]
>
>
>> So that's a bit of a change, but only visually. The "reality" is still
>> the same, we just report it more "accurately." libvirt MIGHT need a
>> heads up here. I'm looping pkrempa back in for comment.
>>
>> <pkrempa>
>> Would libvirt be negatively impacted by the revelation of formerly
>> internal ("implicit") nodes created by mirror and commit via query block
>> commands? At the moment, QEMU hides them from you if you do not name them.
>
> Currently we would not be able to handle that properly at least
> definitely in the pre-blockdev case. In blockdev case I must make sure
> that it will work.
>
> The thing is that I didn't really want to touch the pre-blockdev case
> code any more,
Aren't you going to deprecate and drop it at some moment?
but if you decide that we should do it I'm willing to
> investigate this case also for the old commands.
>
>> </pkrempa>
>>
>>> 3. bdrv_refresh_filename, bdrv_reopen_parse_backing, bdrv_drop_intermediate:
>>> I think it's not a problem, just drop special case for implicit fitlers
>>>
>>
>> I'm much less certain about what the impact of this would be and would
>> need to audit it (and don't have the time to, personally.)
>>
>> Do you have a POC or RFC patch that demonstrates dropping these special
>> cases? It might be nice to see as proof that it's safe to deprecate.
>>
>>> So, seems the only real change is query-block and query-blockstats output when mirror or commit is started
>>> without specifying filter-node-name (filter would be on top)
>>>
>>> So, how should we deprecate this, or can we just change it?
>>>
>>
>> I'm not sure if it's worth it yet, what does dropping the implicit field
>> buy us? Conceptually I understand that it's simpler without the notion
>> of implicit fields, but I imagine there's some cleanup in particular
>> that motivated this.
>>
>> I'd say to just change the behavior, we should:
>>
>> - Give a standard three-release warning that the behavior will change in
>> an incompatible way
>> - Demonstrate with an RFC patch that special cases around ->implicit in
>> block.c can be removed and do not make the code more complex,
>> - Get blessings from Peter Krempa.
>>
>> As always: Libvirt is not the end-all be-all of QEMU management, but if
>> libvirt is capable of working around design changes then I believe any
>> project out there today also could, so it's a good litmus test.
>
> For libvirt we really care more whether a node is format/protocol
> related or not rather than whether it's implicit or not.
>
> In this case we could filter it by the known protocol and format driver
> types and filter out the rest in cases when we e.g. detect the node
> names for the pre-blockdev era cases.
>
> (Note that even with new qemu, if an SD card is used blockdev will be
> disabled).
>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-08-29 15:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:07 [Qemu-devel] [PATCH 0/2] Deprecate implicit filters Vladimir Sementsov-Ogievskiy
2019-08-14 10:07 ` [Qemu-devel] [PATCH 1/2] qapi: deprecate drive-mirror and drive-backup Vladimir Sementsov-Ogievskiy
2019-08-14 19:22 ` John Snow
2019-08-15 7:44 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-08-15 21:24 ` John Snow
2019-08-14 10:07 ` [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters Vladimir Sementsov-Ogievskiy
2019-08-14 19:27 ` John Snow
2019-08-14 20:34 ` [Qemu-devel] [Qemu-block] " Maxim Levitsky
2019-08-15 10:49 ` [Qemu-devel] " Kevin Wolf
2019-08-15 11:45 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-08-15 14:04 ` Markus Armbruster
2019-08-29 16:45 ` Christophe de Dinechin
2019-08-29 17:57 ` John Snow
2019-08-30 10:07 ` Christophe de Dinechin
2019-08-30 18:11 ` John Snow
2019-09-02 12:04 ` Kevin Wolf
2019-11-22 8:41 ` Markus Armbruster
2019-11-22 11:32 ` Christophe de Dinechin
2019-08-15 16:07 ` [Qemu-devel] " John Snow
2019-08-15 16:48 ` Kevin Wolf
2019-08-15 17:33 ` John Snow
2019-08-15 19:24 ` Markus Armbruster
2019-08-16 8:20 ` Kevin Wolf
2019-08-16 12:33 ` Markus Armbruster
2019-08-16 12:58 ` Vladimir Sementsov-Ogievskiy
2019-08-15 14:16 ` [Qemu-devel] Exposing feature deprecation to machine clients (was: [PATCH 2/2] qapi: deprecate implicit filters) Markus Armbruster
2019-08-15 17:40 ` John Snow
2019-11-07 18:52 ` [Qemu-devel] Exposing feature deprecation to machine clients Philippe Mathieu-Daudé
2019-11-07 19:13 ` Vladimir Sementsov-Ogievskiy
2019-11-08 6:41 ` Deprecating stuff for 4.2 (was: [Qemu-devel] Exposing feature deprecation to machine clients) Markus Armbruster
2019-11-08 9:36 ` Deprecating stuff for 4.2 Vladimir Sementsov-Ogievskiy
2019-11-08 8:35 ` [Qemu-devel] Exposing feature deprecation to machine clients Max Reitz
2019-08-29 15:59 ` [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters Christophe de Dinechin
2019-08-29 17:18 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-23 9:22 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy
2019-08-27 20:12 ` John Snow
2019-08-28 9:20 ` Vladimir Sementsov-Ogievskiy
2019-08-28 17:48 ` John Snow
2019-08-29 14:44 ` Peter Krempa
2019-08-29 15:17 ` Vladimir Sementsov-Ogievskiy [this message]
2019-08-29 17:50 ` John Snow
2019-08-29 15:00 ` Vladimir Sementsov-Ogievskiy
2019-08-29 15:16 ` Vladimir Sementsov-Ogievskiy
2019-09-02 12:14 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e0c5d2-4c2f-0565-140d-b16c3e4a87b8@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).