From: Claudio Fontana <cfontana@suse.de>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"open list:X86 HAXM CPUs" <haxm-team@intel.com>,
"Colin Xu" <colin.xu@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wenchao Wang" <wenchao.wang@intel.com>
Subject: Re: [RFC 1/3] cpu-throttle: new module, extracted from cpus.c
Date: Fri, 22 May 2020 12:54:27 +0200 [thread overview]
Message-ID: <e3c07225-b502-6bbc-3c6d-eda54b429c91@suse.de> (raw)
In-Reply-To: <87r1vce04i.fsf@linaro.org>
On 5/22/20 12:26 PM, Alex Bennée wrote:
>
> Claudio Fontana <cfontana@suse.de> writes:
>
>> On 5/22/20 8:07 AM, Thomas Huth wrote:
>>>> From: "Claudio Fontana" <cfontana@suse.de>
>>>> Sent: Thursday, May 21, 2020 8:54:05 PM
>>>>
>>>> this is a first step in the refactoring of cpus.c.
>>>
>>> Could you maybe extend the commit message in the next version a little bit? ... say something about *what* you are moving to a separate file (and maybe why it is ok to move it), etc.?
>>>
>>> Thanks,
>>> Thomas
>>>
>>>
>>
>> Hello Thomas,
>>
>> thanks for taking a look, I will add an explanatory message.
>>
>> I was thinking something along the lines of:
>>
>> "
>> move the vcpu throttling functionality into its own module.
>> It contains the controls to adjust and inspect vcpu throttling settings, start (set) and stop
>> vcpu throttling, and the throttling function itself that is run periodically on vcpus
>> to make them take a nap.
>> Execution of the throttling function on all vcpus is triggered by a timer,
>> registered at module initialization.
>>
>> No functionality change.
>> "
>
> Is vcpu throttling a TCG only feature?
>
No, are you suggesting we only refactor code out of cpus.c based on whether it's tcg or not?
Ciao,
Claudio
next prev parent reply other threads:[~2020-05-22 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 18:54 [RFC 0/3] QEMU cpus.c refactoring Claudio Fontana
2020-05-21 18:54 ` [RFC 1/3] cpu-throttle: new module, extracted from cpus.c Claudio Fontana
2020-05-22 6:07 ` Thomas Huth
2020-05-22 8:15 ` Claudio Fontana
2020-05-22 10:26 ` Alex Bennée
2020-05-22 10:54 ` Claudio Fontana [this message]
2020-05-22 11:18 ` Alex Bennée
2020-05-22 11:23 ` Claudio Fontana
2020-05-21 18:54 ` [RFC 2/3] cpu-timers: new module " Claudio Fontana
2020-05-22 13:49 ` Claudio Fontana
2020-05-21 18:54 ` [RFC 3/3] cpus: implement cpus interfaces for per-accel threads Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3c07225-b502-6bbc-3c6d-eda54b429c91@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=colin.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=haxm-team@intel.com \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=rth@twiddle.net \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).