Re: [RFC 1/3] cpu-throttle: new module, extracted from cpus.c

From: Claudio Fontana <cfontana@suse.de>
To: Thomas Huth <thuth@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>,
	"open list:X86 HAXM CPUs" <haxm-team@intel.com>,
	"Colin Xu" <colin.xu@intel.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Sunil Muthuswamy" <sunilmut@microsoft.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Wenchao Wang" <wenchao.wang@intel.com>
Subject: Re: [RFC 1/3] cpu-throttle: new module, extracted from cpus.c
Date: Fri, 22 May 2020 10:15:42 +0200	[thread overview]
Message-ID: <e64d5b81-8759-15ca-2486-dcc8ed10edc0@suse.de> (raw)
In-Reply-To: <1934989075.27890087.1590127622669.JavaMail.zimbra@redhat.com>

On 5/22/20 8:07 AM, Thomas Huth wrote:
>> From: "Claudio Fontana" <cfontana@suse.de>
>> Sent: Thursday, May 21, 2020 8:54:05 PM
>>
>> this is a first step in the refactoring of cpus.c.
> 
> Could you maybe extend the commit message in the next version a little bit? ... say something about *what* you are moving to a separate file (and maybe why it is ok to move it), etc.?
> 
>  Thanks,
>   Thomas
> 
> 

Hello Thomas,

thanks for taking a look, I will add an explanatory message.

I was thinking something along the lines of:

"
move the vcpu throttling functionality into its own module.
It contains the controls to adjust and inspect vcpu throttling settings, start (set) and stop
vcpu throttling, and the throttling function itself that is run periodically on vcpus
to make them take a nap.
Execution of the throttling function on all vcpus is triggered by a timer,
registered at module initialization.

No functionality change.
"

Thanks,

Claudio