From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: tmgross@umich.edu, fujita.tomonori@gmail.com
Cc: netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
andrew@lunn.ch, miguel.ojeda.sandonis@gmail.com, greg@kroah.com
Subject: Re: [PATCH v2 1/3] rust: core abstractions for network PHY drivers
Date: Sun, 08 Oct 2023 07:33:43 +0900 (JST) [thread overview]
Message-ID: <20231008.073343.1435734022238977973.fujita.tomonori@gmail.com> (raw)
In-Reply-To: <20231007.195857.292080693191739384.fujita.tomonori@gmail.com>
On Sat, 07 Oct 2023 19:58:57 +0900 (JST)
FUJITA Tomonori <fujita.tomonori@gmail.com> wrote:
>>> +/// # Examples
>>> +///
>>> +/// ```ignore
>>> +///
>>> +/// use kernel::net::phy::{self, DeviceId, Driver};
>>> +/// use kernel::prelude::*;
>>> +///
>>> +/// kernel::module_phy_driver! {
>>> +/// drivers: [PhyAX88772A, PhyAX88772C, PhyAX88796B],
>>> +/// device_table: [
>>> +/// DeviceId::new_with_driver::<PhyAX88772A>(),
>>> +/// DeviceId::new_with_driver::<PhyAX88772C>(),
>>> +/// DeviceId::new_with_driver::<PhyAX88796B>()
>>> +/// ],
>>> +/// type: RustAsixPhy,
>>> +/// name: "rust_asix_phy",
>>> +/// author: "Rust for Linux Contributors",
>>> +/// description: "Rust Asix PHYs driver",
>>> +/// license: "GPL",
>>> +/// }
>>> +/// ```
>>
>> I can't find the discussion we had about this, but you said you have
>> the `type` parameter to be consistent with `module!`, correct?
>
> No, `driver!` in rust branch, which is used by platform, amba, etc.
>
> https://github.com/Rust-for-Linux/linux/blob/rust/samples/rust/rust_platform.rs
>
>> I think that it is more important to be consistent with C's
>> `MODULE_PHY_DRIVER` where you don't need to specify anything extra,
>> since the module doesn't do anything else. And I think it is less
>> confusing for users if they don't wonder why they need to define a
>> type they never use.
>>
>> Why not just remove the field and create an internal type based on
>> `name` for now? We can always make it an optional field later on if it
>> turns out there is a use case.
>
> Sure, I'll try. I have no preference and driver! macro isn't in
> upstream.
To create an internal type based on `name`, we need to unstringify
`name`? I can't find a easy way to do it.
next prev parent reply other threads:[~2023-10-07 22:33 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 9:49 [PATCH v2 0/3] Rust abstractions for network PHY drivers FUJITA Tomonori
2023-10-06 9:49 ` [PATCH v2 1/3] rust: core " FUJITA Tomonori
2023-10-07 5:06 ` Trevor Gross
2023-10-07 10:58 ` FUJITA Tomonori
2023-10-07 11:17 ` Greg KH
2023-10-07 11:23 ` FUJITA Tomonori
2023-10-07 11:30 ` Greg KH
2023-10-07 22:33 ` FUJITA Tomonori [this message]
2023-10-08 6:19 ` Trevor Gross
2023-10-08 7:49 ` FUJITA Tomonori
2023-10-08 8:54 ` Trevor Gross
2023-10-08 9:02 ` FUJITA Tomonori
2023-10-08 9:58 ` Trevor Gross
2023-10-07 23:26 ` Trevor Gross
2023-10-07 14:47 ` Andrew Lunn
2023-10-08 5:41 ` Trevor Gross
2023-10-07 15:13 ` Andrew Lunn
2023-10-08 6:07 ` Trevor Gross
2023-10-08 14:28 ` FUJITA Tomonori
2023-10-09 3:07 ` Trevor Gross
2023-10-06 9:49 ` [PATCH v2 2/3] MAINTAINERS: add Rust PHY abstractions to the ETHERNET PHY LIBRARY FUJITA Tomonori
2023-10-06 9:49 ` [PATCH v2 3/3] net: phy: add Rust Asix PHY driver FUJITA Tomonori
2023-10-06 10:31 ` Greg KH
2023-10-06 13:53 ` FUJITA Tomonori
2023-10-06 14:12 ` Greg KH
2023-10-06 14:30 ` FUJITA Tomonori
2023-10-06 14:37 ` Greg KH
2023-10-06 14:40 ` Andrew Lunn
2023-10-06 14:35 ` Andrew Lunn
2023-10-06 15:26 ` FUJITA Tomonori
2023-10-06 15:57 ` Andrew Lunn
2023-10-06 16:21 ` FUJITA Tomonori
2023-10-06 16:55 ` Andrew Lunn
2023-10-06 23:54 ` FUJITA Tomonori
2023-10-07 0:20 ` Andrew Lunn
2023-10-07 7:41 ` FUJITA Tomonori
2023-10-07 7:19 ` Trevor Gross
2023-10-07 12:07 ` FUJITA Tomonori
2023-10-07 15:39 ` Andrew Lunn
2023-10-08 7:11 ` Trevor Gross
2023-10-07 15:35 ` Andrew Lunn
2023-10-08 7:17 ` Trevor Gross
2023-10-06 12:54 ` [PATCH v2 0/3] Rust abstractions for network PHY drivers Andrew Lunn
2023-10-06 14:09 ` FUJITA Tomonori
2023-10-06 14:47 ` Andrew Lunn
2023-10-06 23:37 ` Trevor Gross
2023-10-07 3:26 ` FUJITA Tomonori
2023-10-09 12:39 ` Miguel Ojeda
2023-10-07 0:42 ` Trevor Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231008.073343.1435734022238977973.fujita.tomonori@gmail.com \
--to=fujita.tomonori@gmail.com \
--cc=andrew@lunn.ch \
--cc=greg@kroah.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).