selinux-refpolicy.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jwcart2@tycho.nsa.gov (James Carter)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib
Date: Wed, 11 Apr 2018 14:56:30 -0400	[thread overview]
Message-ID: <20180411185639.23547-1-jwcart2@tycho.nsa.gov> (raw)

The first nine patches cause no change in the final kernel policy.
The last four do because they fix interfaces that were always being
removed because they required an undeclared identifier.

Explanations for some of the patches.

Patches 2 and 3:
spt_lint.lua looks for calls that have too many or too few arguments and
it parses the interface XML header looking for optional and unused
parameters, so by marking parameters that are unused as unused it will
not report a problem.

Patches 5 and 6:
spt_lint.lua will report a problem when a type is used in a module other
than the one that it is declared in. Enforcing this helps reduce the
amount of inter-module dependencies.

Patches 7 - 9:
These patches fix interfaces that are not used in the policy. This is why
they do not change the final policy.

Patches 10 - 13:
These patches fix intefaces (or interface call) that are used in the policy.
These do cause a change in the final policy.

James Carter (13):
  Remove unnecessary semicolons
  Mark unused parameter as unused
  Add unused parameter and mark as unused
  Remove use of undeclared attribute from portage.te
  Move use of httpd_t from mojomojo.te to apache.te
  Move use of sendmail_exec_t from sendmail.te to mta.te
  Fix typos in identifier names
  Remove undeclared identifiers from shorewall interfaces
  Fix interfaces that use an undeclared identifier
  Fix typos in identifier names
  Remove undeclared identifiers from interfaces
  Fix interfaces that use an undeclared identifier
  Removed call to deprecated interface xserver_manage_xdm_spool_files()

 accountsd.if      |  2 +-
 alsa.te           |  2 +-
 apache.if         | 19 +++++++++++++++++++
 bugzilla.if       |  2 +-
 ccs.if            |  4 ++--
 cfengine.if       |  4 ++--
 cobbler.if        |  6 +++---
 cron.if           |  4 ++--
 cups.if           |  3 +--
 dbus.if           |  2 +-
 devicekit.if      |  2 +-
 djbdns.if         |  4 ++--
 dspam.if          |  4 ++--
 evolution.if      |  2 +-
 firewalld.if      |  4 ++--
 ftp.te            |  2 +-
 kismet.if         |  4 ++--
 lsm.if            |  2 +-
 mojomojo.te       |  2 +-
 mta.if            | 19 +++++++++++++++++++
 obex.if           |  2 +-
 plymouthd.if      |  2 +-
 plymouthd.te      |  1 -
 portage.te        |  2 --
 qemu.te           |  2 +-
 rabbitmq.if       |  6 ++++--
 rpm.if            |  4 ++--
 rsync.if          |  2 +-
 samba.if          |  3 +--
 samhain.if        |  2 +-
 sectoolm.if       |  2 +-
 sendmail.te       |  3 ++-
 setroubleshoot.if |  5 +++++
 shorewall.if      | 14 ++------------
 sosreport.if      |  2 +-
 sssd.if           |  4 ++--
 tftp.if           |  9 +++++++--
 wm.if             |  2 +-
 38 files changed, 98 insertions(+), 62 deletions(-)

-- 
2.13.6

             reply	other threads:[~2018-04-11 18:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 18:56 James Carter [this message]
2018-04-11 18:56 ` [refpolicy] [PATCH 01/13] Remove unnecessary semicolons James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 02/13] Mark unused parameter as unused James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 03/13] Add unused parameter and mark " James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 04/13] Remove use of undeclared attribute from portage.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 05/13] Move use of httpd_t from mojomojo.te to apache.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 06/13] Move use of sendmail_exec_t from sendmail.te to mta.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 07/13] Fix typos in identifier names James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 08/13] Remove undeclared identifiers from shorewall interfaces James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 09/13] Fix interfaces that use an undeclared identifier James Carter
2018-04-12 22:47 ` [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib Chris PeBenito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180411185639.23547-1-jwcart2@tycho.nsa.gov \
    --to=jwcart2@tycho.nsa.gov \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).