From: jwcart2@tycho.nsa.gov (James Carter)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 07/13] Fix typos in identifier names
Date: Wed, 11 Apr 2018 14:56:37 -0400 [thread overview]
Message-ID: <20180411185639.23547-8-jwcart2@tycho.nsa.gov> (raw)
In-Reply-To: <20180411185639.23547-1-jwcart2@tycho.nsa.gov>
These interfaces are not being called in the policy (or are only called by
interfaces that are not called).
In kismet.if:kismet_role()
kistmet_tmpfs_t should be kismet_tmpfs_t
In obex.if:obex_role_template()
obex_exec_exec_t should be obex_exec_t
In sosreport.if:sosreport_run()
sospreport_roles should be sosreport_roles
Called only in sosreport_role() which is not called in policy.
Signed-off-by: James Carter <jwcart2@tycho.nsa.gov>
---
kismet.if | 4 ++--
obex.if | 2 +-
sosreport.if | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kismet.if b/kismet.if
index 7e61276..1ba783c 100644
--- a/kismet.if
+++ b/kismet.if
@@ -18,12 +18,12 @@
template(`kismet_role',`
gen_require(`
type kismet_exec_t, kismet_home_t, kismet_tmp_t;
- type kistmet_tmpfs_t, kismet_t;
+ type kismet_tmpfs_t, kismet_t;
')
kismet_run($1, $2)
- allow $2 kistmet_t:process { ptrace signal_perms };
+ allow $2 kismet_t:process { ptrace signal_perms };
ps_process_pattern($2, kismet_t)
allow $2 kismet_home_t:dir { manage_dir_perms relabel_dir_perms };
diff --git a/obex.if b/obex.if
index 410c0e8..6723697 100644
--- a/obex.if
+++ b/obex.if
@@ -24,7 +24,7 @@
template(`obex_role_template',`
gen_require(`
attribute_role obex_roles;
- type obex_t, obex_exec_exec_t;
+ type obex_t, obex_exec_t;
')
########################################
diff --git a/sosreport.if b/sosreport.if
index 634c6b4..e1edfd9 100644
--- a/sosreport.if
+++ b/sosreport.if
@@ -42,7 +42,7 @@ interface(`sosreport_run',`
')
sosreport_domtrans($1)
- roleattribute $2 sospreport_roles;
+ roleattribute $2 sosreport_roles;
')
########################################
--
2.13.6
next prev parent reply other threads:[~2018-04-11 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 18:56 [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 01/13] Remove unnecessary semicolons James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 02/13] Mark unused parameter as unused James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 03/13] Add unused parameter and mark " James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 04/13] Remove use of undeclared attribute from portage.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 05/13] Move use of httpd_t from mojomojo.te to apache.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 06/13] Move use of sendmail_exec_t from sendmail.te to mta.te James Carter
2018-04-11 18:56 ` James Carter [this message]
2018-04-11 18:56 ` [refpolicy] [PATCH 08/13] Remove undeclared identifiers from shorewall interfaces James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 09/13] Fix interfaces that use an undeclared identifier James Carter
2018-04-12 22:47 ` [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib Chris PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411185639.23547-8-jwcart2@tycho.nsa.gov \
--to=jwcart2@tycho.nsa.gov \
--cc=refpolicy@oss.tresys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).