From: Matthias Brugger <matthias.bgg@gmail.com>
To: Luca Weiss <luca@z3ntu.xyz>, linux-mediatek@lists.infradead.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: dts: mt6589: Add device tree for Fairphone 1
Date: Mon, 15 Nov 2021 17:42:20 +0100 [thread overview]
Message-ID: <62e52ffc-09e5-6b83-540f-f6347fca7adf@gmail.com> (raw)
Message-ID: <20211115164220.Mm_xyNYD2ue7fwJc3EUcnh7HBI-R_qp1SE2PvXCtvHY@z> (raw)
In-Reply-To: <20211024084535.30959-1-luca@z3ntu.xyz>
On 24/10/2021 10:45, Luca Weiss wrote:
> Add rudimentary support for the Fairphone 1, based on MT6589 to boot to
> UART console.
>
> The recently added SMP support needs to be disabled for this board as
> the kernel panics executing /init with it, even though the CPUs seem to
> start up fine - maybe a stability issue.
>
> [ 0.072010] smp: Bringing up secondary CPUs ...
> [ 0.131888] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001
> [ 0.191889] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002
> [ 0.251890] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003
> [ 0.251982] smp: Brought up 1 node, 4 CPUs
> [ 0.254745] SMP: Total of 4 processors activated (7982.28 BogoMIPS).
> [ 0.255582] CPU: All CPU(s) started in SVC mode.
>
> [ 0.472039] Run /init as init process
> [ 0.473317] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Now part of v5.16-next/dts32
Thanks
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/mt6589-fairphone-fp1.dts | 30 ++++++++++++++++++++++
> arch/arm/boot/dts/mt6589.dtsi | 2 +-
> 3 files changed, 32 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/mt6589-fairphone-fp1.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7e0934180724..24f402db2613 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1437,6 +1437,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
> mt2701-evb.dtb \
> mt6580-evbp1.dtb \
> mt6589-aquaris5.dtb \
> + mt6589-fairphone-fp1.dtb \
> mt6592-evb.dtb \
> mt7623a-rfb-emmc.dtb \
> mt7623a-rfb-nand.dtb \
> diff --git a/arch/arm/boot/dts/mt6589-fairphone-fp1.dts b/arch/arm/boot/dts/mt6589-fairphone-fp1.dts
> new file mode 100644
> index 000000000000..c952347981de
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt6589-fairphone-fp1.dts
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2021, Luca Weiss <luca@z3ntu.xyz>
> + */
> +
> +/dts-v1/;
> +#include "mt6589.dtsi"
> +
> +/ {
> + model = "Fairphone 1";
> + compatible = "fairphone,fp1", "mediatek,mt6589";
> +
> + chosen {
> + stdout-path = &uart3;
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x40000000>;
> + };
> +};
> +
> +&cpus {
> + /* SMP is not stable on this board, makes the kernel panic */
> + /delete-property/ enable-method;
> +};
> +
> +&uart3 {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/mt6589.dtsi b/arch/arm/boot/dts/mt6589.dtsi
> index 70df00a7bb26..c6babc8ad2ba 100644
> --- a/arch/arm/boot/dts/mt6589.dtsi
> +++ b/arch/arm/boot/dts/mt6589.dtsi
> @@ -14,7 +14,7 @@ / {
> compatible = "mediatek,mt6589";
> interrupt-parent = <&sysirq>;
>
> - cpus {
> + cpus: cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> enable-method = "mediatek,mt6589-smp";
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-15 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 8:45 [PATCH v2] arm: dts: mt6589: Add device tree for Fairphone 1 Luca Weiss
2021-10-24 8:45 ` Luca Weiss
2021-10-24 8:45 ` Luca Weiss
2021-11-15 16:42 ` Matthias Brugger [this message]
2021-11-15 16:42 ` Matthias Brugger
2021-11-15 16:42 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e52ffc-09e5-6b83-540f-f6347fca7adf@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luca@z3ntu.xyz \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).