From: Dean Wallace <duffydack73@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
Stable <stable@vger.kernel.org>,
Johannes Stezenbach <js@sig21.net>,
Carlo Caione <carlo@endlessm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)
Date: Mon, 29 Oct 2018 19:08:19 +0000 [thread overview]
Message-ID: <20181029190819.2ivlx73n6y6sx4vk@picard> (raw)
In-Reply-To: <CAHp75VctdBE-GM60udJawBCXdmoOqZn4N=kFWz5GLHzjPG2iQQ@mail.gmail.com>
On 29-10-18, Andy Shevchenko wrote:
> On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > Cc: Pierre as well.
> >
> > On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > >
> > > Quoting Dean Wallace (2018-10-25 16:25:17)
> > > > I have found a regression in 4.18.15 that means I lose sound on my old
> > > > Toshiba Chromebook 2 (Swanky). My system details are:-
> > > >
> > > > Toshiba Chromebook (Swanky)
> > > > MrChromebox UEFI coreboot
> > > > Arch Linux running latest alsa/pulseaudio
> > > >
> > > > Upgraded kernel from 4.18.14 to 4.18.15 and lost all sound output. By
> > > > output I mean, the card is still detected, the module loaded, all apps
> > > > showing sound is being playing, but no actual audible sound comes
> > > > through. Upgraded to 4.18.16 same issue.
> > > >
> > > > Dug around and found Upstream commit 648e921888ad96ea3dc922739e96716ad3225d7f
> > > > clk: x86: Stop marking clocks as CLK_IS_CRITICAL
> > > > "This commit removes the CLK_IS_CRITICAL marking, fixing Cherry Trail
> > > > devices not being able to reach S0i3 greatly decreasing their battery
> > > > drain when suspended."
> > > >
> > > > I reverted it and compiled 4.18.16 and have sound back again. Could
> > > > this be looked into, with possibility of fix.
> > > >
> > >
> > > Thanks for the bug report. I'm adding some people involved in the commit
> > > you mention is causing audio regressions. The best plan is to probably
> > > revert the commit from the 4.18 linux stable tree. Or there may be
> > > another patch missing that would be useful to make this backported patch
> > > work. Hopefully Hans or Andy knows.
> >
> > Hans has been investigating S0ix issues on Baytrail and Cherrytrail machines.
> > I have a feeling that the problem can be fixed by properly handling
> > clock in ASoC driver(s). Perhaps Hans and Pierre can figure this out
> > better than me.
>
> Looking to sound/soc/intel/boards/cht_bsw_rt5672.c I see no
> suspend-resume hooks. Perhaps, adding them like in the commit
> ac8bd9e13be2 ("r8169: Disable clk during suspend / resume") would
> help.
>
> Btw, what the drivers are in use for the machine you have? It's better
> you run alsa-info.sh or alike to collect necessary information along
> with output of `lsmod`, `dmesg`, etc.
>
> --
> With Best Regards,
> Andy Shevchenko
alsa-info.txt [1], cpuinfo [2], dmesg [3], and 'ls /sys/bus/i2c/devices' [4]
[1] https://gist.github.com/duffydack/480be8ddced44515dbf981dc09f593ec#file-alsa-info
[2] https://gist.github.com/duffydack/480be8ddced44515dbf981dc09f593ec#file-cpuinfo-log
[3] https://gist.github.com/duffydack/480be8ddced44515dbf981dc09f593ec#file-dmesg-log
[4] https://gist.github.com/duffydack/480be8ddced44515dbf981dc09f593ec#file-sys-bus-i2c-devices-log
Regards
--
Dean
next prev parent reply other threads:[~2018-10-30 3:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181025232517.ywnw54qibemosjws@picard>
2018-10-29 17:45 ` Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) Stephen Boyd
2018-10-29 17:52 ` Andy Shevchenko
2018-10-29 18:04 ` Andy Shevchenko
2018-10-29 19:08 ` Dean Wallace [this message]
2018-10-29 22:03 ` Pierre-Louis Bossart
2018-10-30 10:17 ` Hans de Goede
2018-10-30 11:05 ` Hans de Goede
2018-10-30 16:24 ` Andy Shevchenko
2018-10-30 11:19 ` Hans de Goede
2018-10-30 14:38 ` Dean Wallace
2018-10-30 14:48 ` Hans de Goede
2018-10-30 15:03 ` Andy Shevchenko
2018-10-30 15:25 ` Pierre-Louis Bossart
2018-10-30 15:04 ` Pierre-Louis Bossart
2018-10-30 15:46 ` Hans de Goede
2018-10-30 16:02 ` Hans de Goede
2018-10-30 16:27 ` Pierre-Louis Bossart
2018-10-30 18:31 ` Hans de Goede
2018-10-30 16:03 ` Pierre-Louis Bossart
2018-10-30 16:04 ` Hans de Goede
2018-10-30 16:15 ` Dean Wallace
2018-10-31 11:04 ` Hans de Goede
2018-10-31 12:45 ` Dean Wallace
2018-10-31 20:07 ` Dean Wallace
2018-10-31 22:27 ` Pierre-Louis Bossart
2018-10-31 23:57 ` Dean Wallace
2018-11-01 10:37 ` Dean Wallace
2018-11-01 13:57 ` Hans de Goede
2018-11-01 14:28 ` Dean Wallace
2018-11-01 14:49 ` Hans de Goede
2018-11-01 15:29 ` Dean Wallace
2018-11-01 15:39 ` Dean Wallace
2018-11-01 15:50 ` Dean Wallace
2018-11-02 10:27 ` Hans de Goede
2018-11-02 11:15 ` Dean Wallace
2018-11-01 13:56 ` Hans de Goede
2018-10-30 18:56 ` Mogens Jensen
2018-10-30 19:10 ` Hans de Goede
2018-10-31 6:02 ` Mogens Jensen
2018-10-31 9:29 ` Hans de Goede
2018-10-31 10:03 ` Dean Wallace
2018-11-01 6:55 ` Mogens Jensen
2018-12-02 12:25 ` Hans de Goede
2019-01-17 5:58 ` Mogens Jensen
2019-01-17 9:12 ` Dean Wallace
2019-01-17 12:05 ` Hans de Goede
2019-01-17 13:05 ` Johannes Stezenbach
2019-01-17 13:16 ` Dean Wallace
2019-01-18 15:33 ` Hans de Goede
2019-01-17 19:30 ` Mogens Jensen
2019-01-18 15:35 ` Hans de Goede
2019-01-21 5:55 ` Mogens Jensen
2019-01-22 19:27 ` Pierre-Louis Bossart
2019-01-25 5:16 ` Mogens Jensen
2019-01-25 14:12 ` Pierre-Louis Bossart
2019-01-25 17:57 ` Pierre-Louis Bossart
2019-01-25 20:30 ` Andy Shevchenko
2019-01-24 10:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029190819.2ivlx73n6y6sx4vk@picard \
--to=duffydack73@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=carlo@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=js@sig21.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).