* [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'
@ 2020-01-21 15:54 Eugeniu Rosca
2020-01-21 16:28 ` Will Deacon
[not found] ` <20200122022626.797B324677@mail.kernel.org>
0 siblings, 2 replies; 3+ messages in thread
From: Eugeniu Rosca @ 2020-01-21 15:54 UTC (permalink / raw)
To: Masahiro Yamada, Catalin Marinas, Will Deacon
Cc: stable, linux-arm-kernel, linux-kernel, Eugeniu Rosca,
Eugeniu Rosca, Dirk Behme
From: Dirk Behme <dirk.behme@de.bosch.com>
Since v4.3-rc1 commit 0723c05fb75e44 ("arm64: enable more compressed
Image formats"), it is possible to build Image.{bz2,lz4,lzma,lzo}
AArch64 images. However, the commit missed adding support for removing
those images on 'make ARCH=arm64 (dist)clean'.
Fix this by adding them to the target list.
Make sure to match the order of the recipes in the makefile.
Cc: stable@vger.kernel.org # v4.3+
Fixes: 0723c05fb75e44 ("arm64: enable more compressed Image formats")
Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
v2:
- Added 'Fixes:', 'Cc: stable' and 'Reviewed-by' tags
---
arch/arm64/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/Makefile b/arch/arm64/boot/Makefile
index 1f012c506434..cd3414898d10 100644
--- a/arch/arm64/boot/Makefile
+++ b/arch/arm64/boot/Makefile
@@ -16,7 +16,7 @@
OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
-targets := Image Image.gz
+targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo
$(obj)/Image: vmlinux FORCE
$(call if_changed,objcopy)
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'
2020-01-21 15:54 [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean' Eugeniu Rosca
@ 2020-01-21 16:28 ` Will Deacon
[not found] ` <20200122022626.797B324677@mail.kernel.org>
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-01-21 16:28 UTC (permalink / raw)
To: Eugeniu Rosca
Cc: Masahiro Yamada, Catalin Marinas, stable, linux-arm-kernel,
linux-kernel, Eugeniu Rosca, Dirk Behme
On Tue, Jan 21, 2020 at 04:54:39PM +0100, Eugeniu Rosca wrote:
> From: Dirk Behme <dirk.behme@de.bosch.com>
>
> Since v4.3-rc1 commit 0723c05fb75e44 ("arm64: enable more compressed
> Image formats"), it is possible to build Image.{bz2,lz4,lzma,lzo}
> AArch64 images. However, the commit missed adding support for removing
> those images on 'make ARCH=arm64 (dist)clean'.
>
> Fix this by adding them to the target list.
> Make sure to match the order of the recipes in the makefile.
>
> Cc: stable@vger.kernel.org # v4.3+
> Fixes: 0723c05fb75e44 ("arm64: enable more compressed Image formats")
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> ---
> v2:
> - Added 'Fixes:', 'Cc: stable' and 'Reviewed-by' tags
> ---
> arch/arm64/boot/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, I'll pick this up.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean'
[not found] ` <20200122022626.797B324677@mail.kernel.org>
@ 2020-01-22 13:27 ` Eugeniu Rosca
0 siblings, 0 replies; 3+ messages in thread
From: Eugeniu Rosca @ 2020-01-22 13:27 UTC (permalink / raw)
To: Sasha Levin
Cc: Eugeniu Rosca, Dirk Behme, Masahiro Yamada, stable,
linux-arm-kernel, Eugeniu Rosca
Hi Sasha,
On Wed, Jan 22, 2020 at 02:26:25AM +0000, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 0723c05fb75e ("arm64: enable more compressed Image formats").
>
> The bot has tested the following trees: v5.4.13, v4.19.97, v4.14.166, v4.9.210, v4.4.210.
>
> v5.4.13: Build OK!
> v4.19.97: Build OK!
> v4.14.166: Build OK!
> v4.9.210: Build OK!
> v4.4.210: Failed to apply! Possible dependencies:
> f8fa70f392fa ("arm64: localise Image objcopy flags")
The heuristics of your scripts is correct.
Upon picking f8fa70f392fa ("arm64: localise Image objcopy flags")
first, the backporting conflict of ("arm64: kbuild: remove compressed
images on 'make ARCH=arm64 (dist)clean'") is avoided.
>
> NOTE: The patch will not be queued to stable trees until it is upstream.
>
> How should we proceed with this patch?
Shared my thoughts above. Any other input needed?
--
Best Regards
Eugeniu Rosca
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-22 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 15:54 [PATCH v2] arm64: kbuild: remove compressed images on 'make ARCH=arm64 (dist)clean' Eugeniu Rosca
2020-01-21 16:28 ` Will Deacon
[not found] ` <20200122022626.797B324677@mail.kernel.org>
2020-01-22 13:27 ` Eugeniu Rosca
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).