From: Greg KH <gregkh@linuxfoundation.org>
To: Dakshaja Uppalapati <dakshaja@chelsio.com>
Cc: hch@lst.de, sagi@grimberg.me, stable@vger.kernel.org,
bharat@chelsio.com, nirranjan@chelsio.com
Subject: Re: nvme blk_update_request IO error is seen on stable kernel 5.4.41.
Date: Tue, 26 May 2020 12:25:42 +0200 [thread overview]
Message-ID: <20200526102542.GA2772976@kroah.com> (raw)
In-Reply-To: <20200521140642.GA4724@chelsio.com>
On Thu, May 21, 2020 at 07:36:43PM +0530, Dakshaja Uppalapati wrote:
> Hi all,
>
> Issue which is reported in https://lore.kernel.org/linux-nvme/CH2PR12MB40050ACF
> 2C0DC7439355ED3FDD270@CH2PR12MB4005.namprd12.prod.outlook.com/T/#r8cfc80b26f0cd
> 1cde41879a68fd6a71186e9594c is also seen on stable kernel 5.4.41.
What issue is that? Your url is wrapped and can not work here :(
> In upstream issue is fixed with commit b716e6889c95f64b.
Is this a regression or support for something new that has never worked
before?
> For stable 5.4 kernel it doesn’t apply clean and needs pulling in the following
> commits.
>
> commit 2cb6963a16e9e114486decf591af7cb2d69cb154
> Author: Christoph Hellwig <hch@lst.de>
> Date: Wed Oct 23 10:35:41 2019 -0600
>
> commit 6f86f2c9d94d55c4d3a6f1ffbc2e1115b5cb38a8
> Author: Christoph Hellwig <hch@lst.de>
> Date: Wed Oct 23 10:35:42 2019 -0600
>
> commit 59ef0eaa7741c3543f98220cc132c61bf0230bce
> Author: Christoph Hellwig <hch@lst.de>
> Date: Wed Oct 23 10:35:43 2019 -0600
>
> commit e9061c397839eea34207668bfedce0a6c18c5015
> Author: Christoph Hellwig <hch@lst.de>
> Date: Wed Oct 23 10:35:44 2019 -0600
>
> commit b716e6889c95f64ba32af492461f6cc9341f3f05
> Author: Sagi Grimberg <sagi@grimberg.me>
> Date: Sun Jan 26 23:23:28 2020 -0800
>
> I tried a patch by including only necessary parts of the commits e9061c397839,
> 59ef0eaa7741 and b716e6889c95. PFA.
>
> With the attached patch, issue is not seen.
>
> Please let me know on how to fix it in stable, can all above 5 changes be
> cleanly pushed or if attached shorter version can be pushed?
Do all of the above patches apply cleanly? Do they need to be
backported? Have you tested that? Do you have such a series of patches
so we can compare them?
The patch below is not in any format that I can take it in. ALso, 95%
of the times we take a patch that is different from what is upstream
will have bugs and problems over time because of that. So I always want
to take the original upstream patches instead if at all possible.
So I need a lot more information here in order to try to determine this,
sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-26 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 14:06 nvme blk_update_request IO error is seen on stable kernel 5.4.41 Dakshaja Uppalapati
2020-05-26 7:35 ` Dakshaja Uppalapati
2020-05-26 8:19 ` Greg KH
2020-05-26 10:25 ` Greg KH [this message]
2020-05-28 7:44 ` Dakshaja Uppalapati
2020-05-28 8:34 ` Greg KH
2020-06-01 16:21 ` Dakshaja Uppalapati
2020-06-01 16:27 ` Greg KH
2020-06-01 16:45 ` Dakshaja Uppalapati
2020-06-01 16:52 ` Dakshaja Uppalapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526102542.GA2772976@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bharat@chelsio.com \
--cc=dakshaja@chelsio.com \
--cc=hch@lst.de \
--cc=nirranjan@chelsio.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).