From: Greg KH <gregkh@linuxfoundation.org>
To: Dakshaja Uppalapati <dakshaja@chelsio.com>
Cc: hch@lst.de, sagi@grimberg.me, stable@vger.kernel.org,
nirranjan@chelsio.com, bharat@chelsio.com
Subject: Re: nvme blk_update_request IO error is seen on stable kernel 5.4.41.
Date: Mon, 1 Jun 2020 18:27:50 +0200 [thread overview]
Message-ID: <20200601162750.GA887723@kroah.com> (raw)
In-Reply-To: <20200601162143.GA917@chelsio.com>
On Mon, Jun 01, 2020 at 09:51:44PM +0530, Dakshaja Uppalapati wrote:
> On Thursday, May 05/28/20, 2020 at 10:34:03 +0200, Greg KH wrote:
> > On Thu, May 28, 2020 at 01:14:31PM +0530, Dakshaja Uppalapati wrote:
> > > On Tuesday, May 05/26/20, 2020 at 12:25:42 +0200, Greg KH wrote:
> > > > On Thu, May 21, 2020 at 07:36:43PM +0530, Dakshaja Uppalapati wrote:
> > > > > Hi all,
> > > > >
> > > > > Issue which is reported in https://lore.kernel.org/linux-nvme/CH2PR12MB40050ACF
> > > > > 2C0DC7439355ED3FDD270@CH2PR12MB4005.namprd12.prod.outlook.com/T/#r8cfc80b26f0cd
> > > > > 1cde41879a68fd6a71186e9594c is also seen on stable kernel 5.4.41.
> > > >
> > > > What issue is that? Your url is wrapped and can not work here :(
> > >
> > > Sorry for that, when I tried to format the disk discovered from target machine
> > > the below error is seen in dmesg.
> > >
> > > dmesg:
> > > [ 1844.868480] blk_update_request: I/O error, dev nvme0c0n1, sector 0
> > > op 0x3:(DISCARD) flags 0x4000800 phys_seg 1 prio class 0
> > >
> > > The above issue is seen from kernel-5.5-rc1 onwards.
> > >
> > > >
> > > > > In upstream issue is fixed with commit b716e6889c95f64b.
> > > >
> > > > Is this a regression or support for something new that has never worked
> > > > before?
> > > >
> > >
> > > This is a regression, bisects points to the commit 530436c4 and fixed with
> > > commit b716e688 in upstream.
> > >
> > > Now same issue is seen with stable kernel-5.4.41, 530436c4 is part of it.
> >
> > So why don't we just revert 530436c45ef2 ("nvme: Discard workaround for
> > non-conformant devices") from the stable trees? Will that fix the issue
> > for you instead of the much-larger set of backports you are proposing?
> >
> > Also, is this an issue for you in the 4.19 releases? The above
> > mentioned patch showed up in 4.19.92 and 5.4.7.
> >
>
> Yes, on 4.19 stable kernel too issue is seen. By reverting 530436c45ef2 issue
> is not seen on both 4.19 and 5.4 stable kernels. Do you want me to send the
> reverted patch?
Yes please.
thanks,
greg k-h
next prev parent reply other threads:[~2020-06-01 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 14:06 nvme blk_update_request IO error is seen on stable kernel 5.4.41 Dakshaja Uppalapati
2020-05-26 7:35 ` Dakshaja Uppalapati
2020-05-26 8:19 ` Greg KH
2020-05-26 10:25 ` Greg KH
2020-05-28 7:44 ` Dakshaja Uppalapati
2020-05-28 8:34 ` Greg KH
2020-06-01 16:21 ` Dakshaja Uppalapati
2020-06-01 16:27 ` Greg KH [this message]
2020-06-01 16:45 ` Dakshaja Uppalapati
2020-06-01 16:52 ` Dakshaja Uppalapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601162750.GA887723@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bharat@chelsio.com \
--cc=dakshaja@chelsio.com \
--cc=hch@lst.de \
--cc=nirranjan@chelsio.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).