From: Greg KH <gregkh@linuxfoundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
"Sasha Levin" <sashal@kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"Jian Cai" <jiancai@google.com>, "Stefan Agner" <stefan@agner.ch>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
candle.sun@unisoc.com,
"Miles Chen (陳民樺)" <miles.chen@mediatek.com>,
"Stephen Hines" <srhines@google.com>,
"Luis Lozano" <llozano@google.com>,
"Sandeep Patil" <sspatil@google.com>,
"Marc Zyngier" <maz@kernel.org>
Subject: Re: ARCH=arm LLVM_IAS=1 patches for 5.10, 5.4, and 4.19
Date: Mon, 15 Mar 2021 20:06:29 +0100 [thread overview]
Message-ID: <YE+wNS1iiVTU8YGb@kroah.com> (raw)
In-Reply-To: <CAKwvOdmJm3v3sHfopWXrSPFn46qaSX9cna=Nd+FZiN=Nz9zmQQ@mail.gmail.com>
On Mon, Mar 15, 2021 at 10:43:26AM -0700, Nick Desaulniers wrote:
> On Mon, Mar 15, 2021 at 3:37 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > Note that the 5.4 Thumb2 build is still broken today because
> > it carries
> >
> > eff8728fe698 vmlinux.lds.h: Add PGO and AutoFDO input sections
> >
> > but does not carry
> >
> > f77ac2e378be ARM: 9030/1: entry: omit FP emulation for UND exceptions
> > taken in kernel mode
> >
> > which is tagged as a fix for the former patch, and landed in v5.11.
> > (Side question: anyone have a clue why the patch in question was never
> > selected for backporting?)
>
> I will follow up on the rest, but some quick forensics.
>
> f77ac2e378be ("ARM: 9030/1: entry: omit FP emulation for UND
> exceptions taken in kernel mode")
>
> was selected for inclusion into 5.10.y on 2020-12-20:
> https://lore.kernel.org/stable/20201228125038.405690346@linuxfoundation.org/
>
> I actually don't have a
> Subject: FAILED: patch "[PATCH] <oneline>" failed to apply to X.YY-stable tree
> email for this, which seems unusual. I don't know if one wasn't sent,
> or message engine had a hiccup or what, so I don't know if it simply
> failed to apply to older trees. Ard, did you as the author receive
> such an email? Usually everyone cc'ed on the patch gets such emails
> from autosel, it looks like.
autosel does not send out "FAILED" emails. I only send them out for
when a patch is cc: stable and is said to fix a older commit and the
patch does not apply properly.
> Then *later*
> eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections")
> was sent to stable on 2021-01-13:
> https://lore.kernel.org/stable/20210113185758.GA571703@ubuntu-m3-large-x86/
>
> I was cc'ed on both, and didn't notice or forgot that one had
> additional fixes necessary. My mistake.
>
> I think one way to avoid that in the future in a semi automated
> fashion would be to have an in tree script like checkpatch that given
> a sha from mainline would check git log for any Fixes tag that may
> exist on subsequent patches.
I have a script like that, as does Guenter and Sasha. It's very
computationaly expensive so I doubt we can reduce it down into something
for scripts/ as it's only really needed for those of us maintaining
stable kernels. It's not for a normal developer.
> Then it should be possible for any patch
> that itself is backported (contains "commit XXX upstream") to be fed
> in when auto selected or submitted to stable (or before then) to check
> for new fixes. Probably would still need to be run periodically, as
> Fixes: aren't necessarily available when AutoSel runs. For the
> toolchain, we have a bot that watches for reverts for example, but
> non-standard commit messages denoting one patch fixes another makes
> this far from perfect. Would still need to be run periodically,
> because if a Fixes: exists, but hasn't been merged yet, it could get
> missed.
I do re-run my script at times, it does require it to be run every once
in a while. But again, who is going to care about this except me and
Sasha?
> Though I'm curious how the machinery that picks up Fixes: tags works.
> Does it run on a time based cadence? Is it only run as part of
> AutoSel, but not for manual backports sent to the list? Would it have
> picked up on f77ac2e378be at some point?
Maybe it will, mine might have picked it up, who knows, I haven't run it
in a while. But as you say, because it fails to apply, that's a good
reason for me to not backport it.
Anyway, I'm with Arnd here, I don't see the need for these as it's not
fixing a regression and it's not a "simple" set of changes at all for no
real users.
I do backport changes for newer versions of gcc for older stable kernels
in order for my build systems to stay alive, but I never test with clang
so I don't care about those systems :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-15 19:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 19:32 ARCH=arm LLVM_IAS=1 patches for 5.10, 5.4, and 4.19 Nick Desaulniers
2021-03-12 10:12 ` Greg KH
2021-03-12 17:28 ` Nick Desaulniers
2021-03-13 4:07 ` Sasha Levin
2021-03-15 9:08 ` Greg KH
2021-03-15 9:12 ` Greg KH
2021-03-15 9:16 ` Greg KH
2021-03-15 10:37 ` Ard Biesheuvel
2021-03-15 17:43 ` Nick Desaulniers
2021-03-15 17:53 ` Ard Biesheuvel
2021-03-15 22:58 ` Nick Desaulniers
2021-03-15 23:19 ` [PATCH 5.4.y] ARM: 9030/1: entry: omit FP emulation for UND exceptions taken in kernel mode Nick Desaulniers
2021-03-16 6:20 ` Ard Biesheuvel
2021-03-16 16:59 ` [PATCH 5.4 2/2] ARM: 9044/1: vfp: use undef hook for VFP support detection Nick Desaulniers
2021-03-19 10:06 ` Greg KH
2021-03-19 20:14 ` Nick Desaulniers
2021-03-20 11:04 ` Greg KH
2021-03-16 14:02 ` ARCH=arm LLVM_IAS=1 patches for 5.10, 5.4, and 4.19 Sasha Levin
2021-03-15 19:06 ` Greg KH [this message]
2021-03-15 20:43 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE+wNS1iiVTU8YGb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=candle.sun@unisoc.com \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jiancai@google.com \
--cc=llozano@google.com \
--cc=maz@kernel.org \
--cc=miles.chen@mediatek.com \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=sashal@kernel.org \
--cc=srhines@google.com \
--cc=sspatil@google.com \
--cc=stable@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).