* Re: Patch "HID: playstation: require multicolor LED functionality" has been added to the 5.15-stable tree
[not found] <20211121230439.76777-1-sashal@kernel.org>
@ 2021-11-23 10:59 ` Benjamin Tissoires
2021-11-23 11:03 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tissoires @ 2021-11-23 10:59 UTC (permalink / raw)
To: Sasha Levin, 3.8+; +Cc: stable-commits, Jiri Kosina, Jiri Kosina
On Mon, Nov 22, 2021 at 12:04 AM Sasha Levin <sashal@kernel.org> wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> HID: playstation: require multicolor LED functionality
>
> to the 5.15-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> hid-playstation-require-multicolor-led-functionality.patch
> and it can be found in the queue-5.15 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
I am deeply puzzled by this cherry-pick.
The purpose of this patch was to fix fc97b4d6a1a6 ("HID: playstation:
expose DualSense lightbar through a multi-color LED.")
So unless this patch gets backported in stable (and this is *not* a
request to do so), bringing in this patch in 5.15 is wrong.
Cheers,
Benjamin
>
>
>
> commit e3d2570f947ede21072fd5a08c0d4bc40b6688ea
> Author: Jiri Kosina <jkosina@suse.cz>
> Date: Mon Nov 1 15:12:02 2021 +0100
>
> HID: playstation: require multicolor LED functionality
>
> [ Upstream commit d7f1f9fec09adc1d77092cb2db0e56e2a4efd262 ]
>
> The driver requires multicolor LED support; express that in Kconfig.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 3c33bf572d6d3..d78b1c1fb97e9 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -868,6 +868,7 @@ config HID_PLANTRONICS
> config HID_PLAYSTATION
> tristate "PlayStation HID Driver"
> depends on HID
> + depends on LEDS_CLASS_MULTICOLOR
> select CRC32
> select POWER_SUPPLY
> help
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch "HID: playstation: require multicolor LED functionality" has been added to the 5.15-stable tree
2021-11-23 10:59 ` Patch "HID: playstation: require multicolor LED functionality" has been added to the 5.15-stable tree Benjamin Tissoires
@ 2021-11-23 11:03 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-11-23 11:03 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Sasha Levin, 3.8+, stable-commits, Jiri Kosina, Jiri Kosina
On Tue, Nov 23, 2021 at 11:59:25AM +0100, Benjamin Tissoires wrote:
> On Mon, Nov 22, 2021 at 12:04 AM Sasha Levin <sashal@kernel.org> wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > HID: playstation: require multicolor LED functionality
> >
> > to the 5.15-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > hid-playstation-require-multicolor-led-functionality.patch
> > and it can be found in the queue-5.15 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
>
> I am deeply puzzled by this cherry-pick.
>
> The purpose of this patch was to fix fc97b4d6a1a6 ("HID: playstation:
> expose DualSense lightbar through a multi-color LED.")
>
> So unless this patch gets backported in stable (and this is *not* a
> request to do so), bringing in this patch in 5.15 is wrong.
You are right, thanks for catching this, I'll go drop this commit now.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-23 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211121230439.76777-1-sashal@kernel.org>
2021-11-23 10:59 ` Patch "HID: playstation: require multicolor LED functionality" has been added to the 5.15-stable tree Benjamin Tissoires
2021-11-23 11:03 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).