From: Greg KH <greg@kroah.com>
To: dann frazier <dann.frazier@canonical.com>
Cc: "Marc Zyngier" <maz@kernel.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
stable@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Toan Le" <toan@os.amperecomputing.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Stéphane Graber" <stgraber@ubuntu.com>
Subject: Re: [PATCH v5.10] PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup"
Date: Wed, 6 Apr 2022 14:12:27 +0200 [thread overview]
Message-ID: <Yk2Dq9SYXNRigr5i@kroah.com> (raw)
In-Reply-To: <20220405153419.1330755-1-dann.frazier@canonical.com>
On Tue, Apr 05, 2022 at 09:34:19AM -0600, dann frazier wrote:
> From: Marc Zyngier <maz@kernel.org>
>
> commit 1874b6d7ab1bdc900e8398026350313ac29caddb upstream.
>
> Commit 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup")
> killed PCIe on my XGene-1 box (a Mustang board). The machine itself
> is still alive, but half of its storage (over NVMe) is gone, and the
> NVMe driver just times out.
>
> Note that this machine boots with a device tree provided by the
> UEFI firmware (2016 vintage), which could well be non conformant
> with the spec, hence the breakage.
>
> With the patch reverted, the box boots 5.17-rc8 with flying colors.
>
> Link: https://lore.kernel.org/all/Yf2wTLjmcRj+AbDv@xps13.dannf
> Link: https://lore.kernel.org/r/20220321104843.949645-2-maz@kernel.org
> Fixes: 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: stable@vger.kernel.org
> Cc: Rob Herring <robh@kernel.org>
> Cc: Toan Le <toan@os.amperecomputing.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Krzysztof Wilczyński <kw@linux.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Stéphane Graber <stgraber@ubuntu.com>
> Cc: dann frazier <dann.frazier@canonical.com>
> [dannf: minor context adjustment]
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
> drivers/pci/controller/pci-xgene.c | 33 ++++++++++++++++++++----------
> 1 file changed, 22 insertions(+), 11 deletions(-)
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-04-06 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:34 [PATCH v5.10] PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup" dann frazier
2022-04-06 12:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk2Dq9SYXNRigr5i@kroah.com \
--to=greg@kroah.com \
--cc=bhelgaas@google.com \
--cc=dann.frazier@canonical.com \
--cc=kw@linux.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stgraber@ubuntu.com \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).