* [PATCH -next] scsi: target: core: Fix one kernel-doc comment
@ 2023-10-17 3:09 Yang Li
2023-10-17 15:49 ` Mike Christie
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Li @ 2023-10-17 3:09 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, target-devel, linux-kernel, Yang Li, Abaci Robot
Fix one kernel-doc comment to silence the warnings:
drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6844
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/target/target_core_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index c81def3c96df..670cfb7bd426 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1921,7 +1921,7 @@ static void target_queue_submission(struct se_cmd *se_cmd)
/**
* target_submit - perform final initialization and submit cmd to LIO core
- * @cmd: command descriptor to submit
+ * @se_cmd: command descriptor to submit
*
* target_submit_prep or something similar must have been called on the cmd,
* and this must be called from process context.
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: target: core: Fix one kernel-doc comment
2023-10-17 3:09 [PATCH -next] scsi: target: core: Fix one kernel-doc comment Yang Li
@ 2023-10-17 15:49 ` Mike Christie
2023-10-25 2:23 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Mike Christie @ 2023-10-17 15:49 UTC (permalink / raw)
To: Yang Li, martin.petersen
Cc: linux-scsi, target-devel, linux-kernel, Abaci Robot
On 10/16/23 10:09 PM, Yang Li wrote:
> Fix one kernel-doc comment to silence the warnings:
> drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6844
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/target/target_core_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index c81def3c96df..670cfb7bd426 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1921,7 +1921,7 @@ static void target_queue_submission(struct se_cmd *se_cmd)
>
> /**
> * target_submit - perform final initialization and submit cmd to LIO core
> - * @cmd: command descriptor to submit
> + * @se_cmd: command descriptor to submit
> *
> * target_submit_prep or something similar must have been called on the cmd,
> * and this must be called from process context.
Thanks.
Reviewed-by: Mike Christie <michael.christie@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: target: core: Fix one kernel-doc comment
2023-10-17 3:09 [PATCH -next] scsi: target: core: Fix one kernel-doc comment Yang Li
2023-10-17 15:49 ` Mike Christie
@ 2023-10-25 2:23 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-25 2:23 UTC (permalink / raw)
To: Yang Li
Cc: martin.petersen, linux-scsi, target-devel, linux-kernel, Abaci Robot
Yang,
> Fix one kernel-doc comment to silence the warnings:
> drivers/target/target_core_transport.c:1930: warning: Excess function
> parameter 'cmd' description in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Function
> parameter or member 'se_cmd' not described in 'target_submit'
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] scsi: target: core: Fix one kernel-doc comment
2023-10-17 3:09 [PATCH -next] scsi: target: core: Fix one kernel-doc comment Yang Li
2023-10-17 15:49 ` Mike Christie
2023-10-25 2:23 ` Martin K. Petersen
@ 2023-10-30 15:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-30 15:34 UTC (permalink / raw)
To: Yang Li
Cc: Martin K . Petersen, linux-scsi, target-devel, linux-kernel, Abaci Robot
On Tue, 17 Oct 2023 11:09:13 +0800, Yang Li wrote:
> Fix one kernel-doc comment to silence the warnings:
> drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
>
>
Applied to 6.7/scsi-queue, thanks!
[1/1] scsi: target: core: Fix one kernel-doc comment
https://git.kernel.org/mkp/scsi/c/96f41cddbc7b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-30 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 3:09 [PATCH -next] scsi: target: core: Fix one kernel-doc comment Yang Li
2023-10-17 15:49 ` Mike Christie
2023-10-25 2:23 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).