[PATCH] cmd: sbi: Correctly display unknown implementation IDs

[PATCH] cmd: sbi: Correctly display unknown implementation IDs

[Heinrich Schuchardt]

For an unknown implementation ID an output like

    SBI 1.0Unknown implementation ID 16777216
    Extensions:
      sbi_set_timer
      ...

was shown. The number 16777216 is not the implementation ID.

* Show the correct number
* Use a hexadecimal output format
* Add a missing line feed

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 cmd/riscv/sbi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
index 9daf0e247ad..87f7966f06b 100644
--- a/cmd/riscv/sbi.c
+++ b/cmd/riscv/sbi.c
@@ -99,7 +99,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
 			}
 		}
 		if (i == ARRAY_SIZE(implementations))
-			printf("Unknown implementation ID %ld", ret);
+			printf("\nUnknown implementation ID 0x%x", impl_id);
 	}
 	printf("\nMachine:\n");
 	ret = sbi_get_mvendorid(&mvendorid);
-- 
2.43.0

Re: [PATCH] cmd: sbi: Correctly display unknown implementation IDs

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On Wed, Mar 06, 2024 at 03:44:02PM +0100, Heinrich Schuchardt wrote:
> For an unknown implementation ID an output like
> 
>     SBI 1.0Unknown implementation ID 16777216
>     Extensions:
>       sbi_set_timer
>       ...
> 
> was shown. The number 16777216 is not the implementation ID.
> 
> * Show the correct number
> * Use a hexadecimal output format
> * Add a missing line feed
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>  cmd/riscv/sbi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/riscv/sbi.c b/cmd/riscv/sbi.c
> index 9daf0e247ad..87f7966f06b 100644
> --- a/cmd/riscv/sbi.c
> +++ b/cmd/riscv/sbi.c
> @@ -99,7 +99,7 @@ static int do_sbi(struct cmd_tbl *cmdtp, int flag, int argc,
>  			}
>  		}
>  		if (i == ARRAY_SIZE(implementations))
> -			printf("Unknown implementation ID %ld", ret);
> +			printf("\nUnknown implementation ID 0x%x", impl_id);
>  	}
>  	printf("\nMachine:\n");
>  	ret = sbi_get_mvendorid(&mvendorid);
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] cmd: sbi: Correctly display unknown implementation IDs

[Dan Carpenter]

On Wed, Mar 06, 2024 at 03:44:02PM +0100, Heinrich Schuchardt wrote:
> For an unknown implementation ID an output like
> 
>     SBI 1.0Unknown implementation ID 16777216
>     Extensions:
>       sbi_set_timer
>       ...
> 
> was shown. The number 16777216 is not the implementation ID.
> 
> * Show the correct number
> * Use a hexadecimal output format
> * Add a missing line feed
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

Fixes: 89a86dcf6191 ("cmd: sbi: show SBI implementation version")

regards,
dan carpenter