Re: [PATCH v6 2/2] dt-bindings: add xilinx clocking wizard bindings

[Sean Anderson <sean.anderson@seco.com>]

On 6/11/21 11:10 AM, Zhengxun wrote:
 > Add the devicetree binding for the xilinx clocking wizard.
 >
 > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
 > ---
 >   .../clock/xlnx,clocking-wizard.txt            | 43 +++++++++++++++++++
 >   1 file changed, 43 insertions(+)
 >   create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt

Should this be .yml? In general, I believe we only need to document
bindings in U-Boot if they differ from Linux. In Linux, I see that
Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists.
Will you be upstreaming this conversion to yaml?

--Sean

 >
 > diff --git a/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt b/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt
 > new file mode 100644
 > index 0000000000..e0e73ec723
 > --- /dev/null
 > +++ b/doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt
 > @@ -0,0 +1,43 @@
 > +Xilinx clocking wizard bindings
 > +
 > +description:
 > +  The clocking wizard is a soft ip clocking block of Xilinx versal. It
 > +  reads required input clock frequencies from the devicetree and acts as
 > +  clock output.
 > +
 > +properties:
 > +  compatible:
 > +    const: xlnx,clocking-wizard
 > +
 > +  reg:
 > +    maxItems: 1
 > +
 > +  "#clock-cells":
 > +    const: 1
 > +
 > +  clocks:
 > +    items:
 > +      - description: clock input
 > +
 > +  clock-names:
 > +    items:
 > +      - const: clk_in1
 > +
 > +required:
 > +  - compatible
 > +  - reg
 > +  - "#clock-cells"
 > +  - clocks
 > +  - clock-names
 > +
 > +additionalProperties: false
 > +
 > +examples:
 > +  - |
 > +    clkwizard@43c20000  {
 > +        compatible = "xlnx,clocking-wizard";
 > +        reg = <0x43c20000 0x10000>;
 > +        #clock-cells = <1>;
 > +        clock-names = "clk_in1";
 > +        clocks = <&clkc 18>;
 > +    };
 >