u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Zhengxun Li <zhengxunli.mxic@gmail.com>,
	Sean Anderson <sean.anderson@seco.com>
Cc: <u-boot@lists.denx.de>, Michal Simek <michal.simek@xilinx.com>,
	<lukma@denx.de>, <zhengxunli@mxic.com.tw>
Subject: Re: [PATCH v6 2/2] dt-bindings: add xilinx clocking wizard bindings
Date: Wed, 16 Jun 2021 12:04:55 +0200	[thread overview]
Message-ID: <62a2446e-ed7f-7cfa-51cf-c981576eea67@xilinx.com> (raw)
In-Reply-To: <CACY_kjT5U7j5UF8YsTV8xC1QGdsz37Gv8vMmOkwxcy1Q32a2CA@mail.gmail.com>

Hi,

On 6/16/21 5:26 PM, Zhengxun Li wrote:
> Hi Sean,
> 
> Thank you for your reply.
> 
> Sean Anderson <sean.anderson@seco.com> 於 2021年6月15日 週二 下午2:52寫道:
>>
>>
>>
>> On 6/15/21 1:21 PM, Zhengxun Li wrote:
>>  > Hi Michal,
>>  >
>>  > Sean Anderson <sean.anderson@seco.com> 於 2021年6月11日 週五 下午3:07寫道:
>>  >>
>>  >>
>>  >>
>>  >> On 6/11/21 11:10 AM, Zhengxun wrote:
>>  >>   > Add the devicetree binding for the xilinx clocking wizard.
>>  >>   >
>>  >>   > Signed-off-by: Zhengxun <zhengxunli.mxic@gmail.com>
>>  >>   > ---
>>  >>   >   .../clock/xlnx,clocking-wizard.txt            | 43 +++++++++++++++++++
>>  >>   >   1 file changed, 43 insertions(+)
>>  >>   >   create mode 100644 doc/device-tree-bindings/clock/xlnx,clocking-wizard.txt
>>  >>
>>  >> Should this be .yml? In general, I believe we only need to document
>>  >> bindings in U-Boot if they differ from Linux. In Linux, I see that
>>  >> Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.txt exists.
>>
>> Because the binding is documented in Linux, we do not need to document
>> it in U-Boot.
>>
>>  >> Will you be upstreaming this conversion to yaml?
>>
>> This patch documents the binding in yaml. However, the version in Linux
>> is in old-style txt. Will you be sending a patch to Linux to convert
>> this binding to yaml?
> 
> In linux, I saw Shubhrajyoti Datta do this, although it has not been
> accepted yet. The link is below.
> 
> https://patchwork.kernel.org/project/linux-clk/patch/1617886723-27117-2-git-send-email-shubhrajyoti.datta@xilinx.com/
> 
> Should I do this again?

I prefer not to do it. Linux binding will be reviewed by Rob and that
should be enough.

Thanks,
Michal


  reply	other threads:[~2021-06-16 10:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 15:10 [PATCH v6 0/2] Add Xilinx clock wizard driver support Zhengxun
2021-06-11 15:10 ` [PATCH v6 1/2] clk: zynq: Add clock wizard driver Zhengxun
2021-06-11 15:09   ` Sean Anderson
2021-06-16 10:01   ` Michal Simek
2021-06-11 15:10 ` [PATCH v6 2/2] dt-bindings: add xilinx clocking wizard bindings Zhengxun
2021-06-11 15:07   ` Sean Anderson
2021-06-15 17:21     ` Zhengxun Li
2021-06-15 14:52       ` Sean Anderson
2021-06-16 15:26         ` Zhengxun Li
2021-06-16 10:04           ` Michal Simek [this message]
2021-06-17 11:12             ` Zhengxun Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62a2446e-ed7f-7cfa-51cf-c981576eea67@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=lukma@denx.de \
    --cc=sean.anderson@seco.com \
    --cc=u-boot@lists.denx.de \
    --cc=zhengxunli.mxic@gmail.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).