From: yanhong wang <yanhong.wang@starfivetech.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, <u-boot@lists.denx.de>,
Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Cc: Torsten Duwe <duwe@lst.de>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>,
"samin . guo" <samin.guo@starfivetech.com>,
Walker Chen <walker.chen@starfivetech.com>
Subject: Re: [PATCH v4 11/11] configs: starfive: Enable ID EEPROM configuration
Date: Wed, 7 Jun 2023 10:19:03 +0800 [thread overview]
Message-ID: <43d730e1-56e1-c582-4909-637949093357@starfivetech.com> (raw)
In-Reply-To: <a58d05dc-8945-6b32-8db4-deae9fc08c21@siemens.com>
On 2023/6/5 3:23, Jan Kiszka wrote:
> On 25.05.23 11:36, Yanhong Wang wrote:
>> Enabled ID_EEPROM and I2C configuration for StarFive VisionFive2 board.
>>
>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>> ---
>> configs/starfive_visionfive2_defconfig | 19 ++++++++++++++++++-
>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
>> index c57708199d..570a1f53a1 100644
>> --- a/configs/starfive_visionfive2_defconfig
>> +++ b/configs/starfive_visionfive2_defconfig
>> @@ -13,6 +13,7 @@ CONFIG_SYS_PROMPT="StarFive #"
>> CONFIG_OF_LIBFDT_OVERLAY=y
>> CONFIG_DM_RESET=y
>> CONFIG_SPL_MMC=y
>> +CONFIG_SPL_DRIVERS_MISC=y
>> CONFIG_SPL_STACK=0x8180000
>> CONFIG_SPL=y
>> CONFIG_SPL_SPI_FLASH_SUPPORT=y
>> @@ -23,6 +24,7 @@ CONFIG_SPL_OPENSBI_LOAD_ADDR=0x40000000
>> CONFIG_ARCH_RV64I=y
>> CONFIG_CMODEL_MEDANY=y
>> CONFIG_RISCV_SMODE=y
>> +# CONFIG_OF_BOARD_FIXUP is not set
>> CONFIG_FIT=y
>> CONFIG_DISTRO_DEFAULTS=y
>> CONFIG_QSPI_BOOT=y
>> @@ -34,6 +36,8 @@ CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr};fdt addr ${fdtcontroladdr};"
>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2.dtb"
>> CONFIG_DISPLAY_CPUINFO=y
>> CONFIG_DISPLAY_BOARDINFO=y
>> +CONFIG_ID_EEPROM=y
>> +CONFIG_SYS_EEPROM_BUS_NUM=5
>> CONFIG_SPL_MAX_SIZE=0x40000
>> CONFIG_SPL_PAD_TO=0x0
>> CONFIG_SPL_BSS_START_ADDR=0x8040000
>> @@ -45,21 +49,34 @@ CONFIG_CUSTOM_SYS_SPL_MALLOC_ADDR=0x80000000
>> CONFIG_SYS_SPL_MALLOC_SIZE=0x400000
>> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION=y
>> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION=0x2
>> +CONFIG_SPL_I2C=y
>> CONFIG_SPL_DM_SPI_FLASH=y
>> CONFIG_SPL_DM_RESET=y
>> CONFIG_SPL_SPI_LOAD=y
>> CONFIG_SYS_CBSIZE=256
>> CONFIG_SYS_PBSIZE=276
>> CONFIG_SYS_BOOTM_LEN=0x4000000
>> +CONFIG_CMD_EEPROM=y
>> +CONFIG_SYS_EEPROM_SIZE=512
>> +CONFIG_SYS_EEPROM_PAGE_WRITE_BITS=4
>> +CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS=5
>> CONFIG_CMD_MEMINFO=y
>> +CONFIG_CMD_I2C=y
>> CONFIG_CMD_TFTPPUT=y
>> +CONFIG_OF_BOARD=y
>> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>> +CONFIG_SPL_DM_SEQ_ALIAS=y
>> CONFIG_REGMAP=y
>> CONFIG_SYSCON=y
>> CONFIG_SPL_CLK_COMPOSITE_CCF=y
>> CONFIG_CLK_COMPOSITE_CCF=y
>> CONFIG_SPL_CLK_JH7110=y
>> -# CONFIG_I2C is not set
>> +CONFIG_DM_I2C=y
>> +CONFIG_SYS_I2C_DW=y
>> +CONFIG_MISC=y
>> +CONFIG_I2C_EEPROM=y
>> +CONFIG_SPL_I2C_EEPROM=y
>> +CONFIG_SYS_I2C_EEPROM_ADDR=0X50
>> CONFIG_MMC_HS400_SUPPORT=y
>> CONFIG_SPL_MMC_HS400_SUPPORT=y
>> CONFIG_MMC_DW=y
>
> This comes too late: Already patch 4 needs at least CONFIG_ID_EEPROM=y,
> if not more.
>
Moving patch 4 to the series end, is that okay?
> Make sure you don't leave non-bisectable commit series behind. Whenever
> something breaks (like 55171aedda88), people will use bisection to find
> the causing commit, and then they will appreciate not having to deal
> with such hick-ups.
>
> Jan
>
next prev parent reply other threads:[~2023-06-07 2:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 9:36 [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 01/11] net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 02/11] net: dwc_eth_qos: Add StarFive ethernet driver glue layer Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 03/11] eeprom: starfive: Enable ID EEPROM configuration Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 04/11] ram: starfive: Read memory size information from EEPROM Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 05/11] board: starfive: Dynamic configuration of DT for 1.2A and 1.3B Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 06/11] riscv: dts: jh7110: Add ethernet device tree nodes Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 07/11] riscv: dts: jh7110: Combine the board device tree files of 1.2A and 1.3B Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 08/11] riscv: dts: starfive: Add support eeprom device tree node Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 09/11] doc: board: starfive: Reword the make defconfig information Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 10/11] configs: starfive: Enable ethernet configuration for StarFive VisionFive2 Yanhong Wang
2023-06-04 18:53 ` Jan Kiszka
2023-06-06 7:43 ` yanhong wang
2023-05-25 9:36 ` [PATCH v4 11/11] configs: starfive: Enable ID EEPROM configuration Yanhong Wang
2023-06-04 19:23 ` Jan Kiszka
2023-06-07 2:19 ` yanhong wang [this message]
2023-06-07 12:30 ` Jan Kiszka
2023-05-26 7:40 ` [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC Torsten Duwe
2023-06-01 17:44 ` Torsten Duwe
2023-06-02 3:14 ` yanhong wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d730e1-56e1-c582-4909-637949093357@starfivetech.com \
--to=yanhong.wang@starfivetech.com \
--cc=duwe@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=joe.hershberger@ni.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=rfried.dev@gmail.com \
--cc=rick@andestech.com \
--cc=samin.guo@starfivetech.com \
--cc=u-boot@lists.denx.de \
--cc=walker.chen@starfivetech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).