From: Karel Zak <kzak@redhat.com>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: util-linux@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v2 3/3] blkid: support zone reset for wipefs
Date: Wed, 14 Apr 2021 15:57:42 +0200 [thread overview]
Message-ID: <20210414135742.qayizmwjck5dx377@ws.net.home> (raw)
In-Reply-To: <20210414013339.2936229-4-naohiro.aota@wdc.com>
On Wed, Apr 14, 2021 at 10:33:39AM +0900, Naohiro Aota wrote:
> +static int is_conventional(blkid_probe pr, uint64_t offset)
> +{
> + struct blk_zone_report *rep = NULL;
> + size_t rep_size;
> + int ret;
> + uint64_t zone_mask;
> +
> + if (!pr->zone_size)
> + return 1;
> +
> + rep_size = sizeof(struct blk_zone_report) + sizeof(struct blk_zone);
> + rep = calloc(1, rep_size);
> + if (!rep)
> + return -1;
> +
> + zone_mask = ~(pr->zone_size - 1);
> + rep->sector = (offset & zone_mask) >> 9;
> + rep->nr_zones = 1;
> + ret = ioctl(blkid_probe_get_fd(pr), BLKREPORTZONE, rep);
> + if (ret) {
> + free(rep);
> + return -1;
> + }
ret = blkdev_get_zonereport()
:-)
> /**
> * blkid_do_wipe:
> * @pr: prober
> @@ -1267,6 +1310,7 @@ int blkid_do_wipe(blkid_probe pr, int dryrun)
> const char *off = NULL;
> size_t len = 0;
> uint64_t offset, magoff;
> + bool conventional;
BTW, nowhere in libblkid we use "bool". It would be probably better to include
<stdbool.h> to blkidP.h.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2021-04-14 13:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 1:33 [PATCH v2 0/3] implement zone-aware probing/wiping for zoned btrfs Naohiro Aota
2021-04-14 1:33 ` [PATCH v2 1/3] blkid: implement zone-aware probing Naohiro Aota
2021-04-14 9:14 ` Damien Le Moal
2021-04-14 9:17 ` Johannes Thumshirn
2021-04-14 13:31 ` Karel Zak
2021-04-14 15:03 ` Naohiro Aota
2021-04-14 1:33 ` [PATCH v2 2/3] blkid: add magic and probing for zoned btrfs Naohiro Aota
2021-04-14 9:49 ` Johannes Thumshirn
2021-04-14 13:47 ` Karel Zak
2021-04-14 15:08 ` Naohiro Aota
2021-04-16 15:52 ` David Sterba
2021-04-26 1:38 ` Naohiro Aota
2021-04-14 1:33 ` [PATCH v2 3/3] blkid: support zone reset for wipefs Naohiro Aota
2021-04-14 9:13 ` Damien Le Moal
2021-04-14 9:50 ` Johannes Thumshirn
2021-04-14 13:57 ` Karel Zak [this message]
2021-04-16 16:04 ` David Sterba
2021-04-14 14:09 ` [PATCH v2 0/3] implement zone-aware probing/wiping for zoned btrfs Karel Zak
2021-04-14 22:04 ` Damien Le Moal
2021-04-22 14:41 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414135742.qayizmwjck5dx377@ws.net.home \
--to=kzak@redhat.com \
--cc=damien.lemoal@wdc.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).