From: Samuel Holland <samuel@sholland.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, eric@bluelinelabs.com
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Android app whitelist/blacklist feature
Date: Tue, 3 Jul 2018 13:12:10 -0500 [thread overview]
Message-ID: <72472182-2f17-ff6d-f76c-f0fa6c98d45e@sholland.org> (raw)
In-Reply-To: <CAHmME9qQyw-GxJ-1mLNR_DaWspOO8Enc+gKWobvKUcLqZ-Phcg@mail.gmail.com>
On 07/02/18 21:31, Jason A. Donenfeld wrote:
> On Tue, Jul 3, 2018 at 4:27 AM Eric Kuck <eric@bluelinelabs.com> wrote:
>>
>> I was originally thinking the new fragment would be a per-tunnel thing
>> (set when you create the tunnel or edit it), but you’re right - making it
>> a general setting likely makes a whole lot more sense. I can’t think of
>> any use-cases for different tunnels handling different apps.
>
> It might actually make most sense to make it a per-tunnel thing. We'd then
> have to introduce conf key called, "ExemptedApplications=" or something.
> Samuel - any thoughts on this?
Right, trying to make it a global setting requires either some sort of
out-of-band way to pass the information to wg-quick, or rewriting the
configuration file every time the tunnel is brought up.
Since from netd's point of view, this is a per-network setting anyway, I agree
it makes sense to configure it per-tunnel. ExemptedApplications works as a
configuration key, though I prefer ExcludedApplications--the application isn't
just not required to use the tunnel, it's not allowed to use the tunnel.
In that case, here are my UI suggestions:
- Add a button in the editor that switches to a fragment or pops up a Dialog
similar to a MultiSelectListPreference.
- For consistency, checked means excluded -- everything defaults to unchecked.
- The package names of excluded apps are put in the
com.wireguard.config.Interface, and wg-quick handles package name to uid
translation.
How does that sound?
Samuel
next prev parent reply other threads:[~2018-07-03 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 20:35 Android app whitelist/blacklist feature Eric Kuck
2018-07-02 21:43 ` Samuel Holland
2018-07-03 0:22 ` Eric Kuck
2018-07-03 2:21 ` Jason A. Donenfeld
2018-07-03 2:27 ` Eric Kuck
2018-07-03 2:31 ` Jason A. Donenfeld
2018-07-03 18:12 ` Samuel Holland [this message]
2018-07-03 18:17 ` Jason A. Donenfeld
2018-07-04 22:19 ` Eric Kuck
2018-07-05 13:23 ` Jason A. Donenfeld
2018-07-05 13:24 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72472182-2f17-ff6d-f76c-f0fa6c98d45e@sholland.org \
--to=samuel@sholland.org \
--cc=Jason@zx2c4.com \
--cc=eric@bluelinelabs.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).