From: Eric Kuck <eric@bluelinelabs.com>
To: "Jason A. Donenfeld" <jason@zx2c4.com>,
Samuel Holland <samuel@sholland.org>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Android app whitelist/blacklist feature
Date: Wed, 4 Jul 2018 18:19:36 -0400 [thread overview]
Message-ID: <CAMj-8hSEgJv=TSfWBEhRTrbiQbtJauLed6miZcFtS03jDPOBZA@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9qAUveJi6of9TMb_Owffsy-SX+4pQyDMHaz=6COE2CYxQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]
A first pass that only works with GoBackend has just been pushed. Feel free
to make suggestions or requests. This is the first time I’ve used
databinding for more than just a findViewById substitute, so it’s very
possible I didn’t do something canonically.
On July 3, 2018 at 1:17:27 PM, Jason A. Donenfeld (jason@zx2c4.com) wrote:
On Tue, Jul 3, 2018 at 8:12 PM Samuel Holland <samuel@sholland.org> wrote:
> Right, trying to make it a global setting requires either some sort of
> out-of-band way to pass the information to wg-quick, or rewriting the
> configuration file every time the tunnel is brought up.
>
> Since from netd's point of view, this is a per-network setting anyway, I
agree
> it makes sense to configure it per-tunnel. ExemptedApplications works as
a
> configuration key, though I prefer ExcludedApplications--the application
isn't
> just not required to use the tunnel, it's not allowed to use the tunnel.
>
> In that case, here are my UI suggestions:
> - Add a button in the editor that switches to a fragment or pops up a
Dialog
> similar to a MultiSelectListPreference.
> - For consistency, checked means excluded -- everything defaults to
unchecked.
> - The package names of excluded apps are put in the
> com.wireguard.config.Interface, and wg-quick handles package name to uid
> translation.
>
> How does that sound?
All of that sounds right-on to me, and I think you're right that
ExcludedApplications is the better key.
(This also provides a good basis for later adding a
"ExcludeLocalNetwork" option.)
Eric's git access should be all setup now, so we can watch the
commits coming on in.
[-- Attachment #2: Type: text/html, Size: 2403 bytes --]
next prev parent reply other threads:[~2018-07-04 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 20:35 Android app whitelist/blacklist feature Eric Kuck
2018-07-02 21:43 ` Samuel Holland
2018-07-03 0:22 ` Eric Kuck
2018-07-03 2:21 ` Jason A. Donenfeld
2018-07-03 2:27 ` Eric Kuck
2018-07-03 2:31 ` Jason A. Donenfeld
2018-07-03 18:12 ` Samuel Holland
2018-07-03 18:17 ` Jason A. Donenfeld
2018-07-04 22:19 ` Eric Kuck [this message]
2018-07-05 13:23 ` Jason A. Donenfeld
2018-07-05 13:24 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj-8hSEgJv=TSfWBEhRTrbiQbtJauLed6miZcFtS03jDPOBZA@mail.gmail.com' \
--to=eric@bluelinelabs.com \
--cc=jason@zx2c4.com \
--cc=samuel@sholland.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).