From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <paul@xen.org>
Cc: xen-devel@lists.xenproject.org,
Paul Durrant <pdurrant@amazon.com>,
Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v3 03/11] x86/iommu: convert VT-d code to use new page table allocator
Date: Mon, 3 Aug 2020 18:03:57 +0200 [thread overview]
Message-ID: <0eda3f54-63ce-2694-ba3b-2a0c67826098@suse.com> (raw)
In-Reply-To: <20200803122914.2259-4-paul@xen.org>
On 03.08.2020 14:29, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@amazon.com>
>
> This patch converts the VT-d code to use the new IOMMU page table allocator
> function. This allows all the free-ing code to be removed (since it is now
> handled by the general x86 code) which reduces TLB and cache thrashing as well
> as shortening the code.
>
> The scope of the mapping_lock in intel_iommu_quarantine_init() has also been
> increased slightly; it should have always covered accesses to
> 'arch.vtd.pgd_maddr'.
I think I disagree here (this is __init code and hence there's no
risk of races), but anyway (as it doesn't hurt) ...
> NOTE: The common IOMMU needs a slight modification to avoid scheduling the
> cleanup tasklet if the free_page_table() method is not present (since
> the tasklet will unconditionally call it).
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2020-08-03 16:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 12:29 [PATCH v3 00/11] IOMMU cleanup Paul Durrant
2020-08-03 12:29 ` [PATCH v3 01/11] x86/iommu: re-arrange arch_iommu to separate common fields Paul Durrant
2020-08-03 15:53 ` Jan Beulich
2020-08-03 12:29 ` [PATCH v3 02/11] x86/iommu: add common page-table allocator Paul Durrant
2020-08-03 15:58 ` Jan Beulich
2020-08-03 16:17 ` Durrant, Paul
2020-08-03 12:29 ` [PATCH v3 03/11] x86/iommu: convert VT-d code to use new page table allocator Paul Durrant
2020-08-03 16:03 ` Jan Beulich [this message]
2020-08-03 12:29 ` [PATCH v3 04/11] x86/iommu: convert AMD IOMMU " Paul Durrant
2020-08-03 16:05 ` Jan Beulich
2020-08-03 12:29 ` [PATCH v3 05/11] iommu: remove unused iommu_ops method and tasklet Paul Durrant
2020-08-03 16:06 ` Jan Beulich
2020-08-03 12:29 ` [PATCH v3 06/11] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail Paul Durrant
2020-08-03 12:29 ` [PATCH v3 07/11] iommu: make map, unmap and flush all take both an order and a count Paul Durrant
2020-08-03 12:29 ` [PATCH v3 08/11] remove remaining uses of iommu_legacy_map/unmap Paul Durrant
2020-08-03 12:29 ` [PATCH v3 09/11] common/grant_table: batch flush I/O TLB Paul Durrant
2020-08-03 12:29 ` [PATCH v3 10/11] iommu: remove the share_p2m operation Paul Durrant
2020-08-03 12:29 ` [PATCH v3 11/11] iommu: stop calling IOMMU page tables 'p2m tables' Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eda3f54-63ce-2694-ba3b-2a0c67826098@suse.com \
--to=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).