From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <paul@xen.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Paul Durrant" <pdurrant@amazon.com>,
"Lukasz Hawrylko" <lukasz.hawrylko@linux.intel.com>,
xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 01/11] x86/iommu: re-arrange arch_iommu to separate common fields...
Date: Mon, 3 Aug 2020 17:53:13 +0200 [thread overview]
Message-ID: <2a5a0a65-81aa-2c1f-c98a-5e6fd54ba3df@suse.com> (raw)
In-Reply-To: <20200803122914.2259-2-paul@xen.org>
On 03.08.2020 14:29, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@amazon.com>
>
> ... from those specific to VT-d or AMD IOMMU, and put the latter in a union.
>
> There is no functional change in this patch, although the initialization of
> the 'mapped_rmrrs' list occurs slightly later in iommu_domain_init() since
> it is now done (correctly) in VT-d specific code rather than in general x86
> code.
>
> NOTE: I have not combined the AMD IOMMU 'root_table' and VT-d 'pgd_maddr'
> fields even though they perform essentially the same function. The
> concept of 'root table' in the VT-d code is different from that in the
> AMD code so attempting to use a common name will probably only serve
> to confuse the reader.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
with a remark (can be taken care of while committing if no other
need for a v4 arises):
> @@ -598,11 +600,12 @@ static void amd_dump_p2m_table(struct domain *d)
> {
> const struct domain_iommu *hd = dom_iommu(d);
>
> - if ( !hd->arch.root_table )
> + if ( !hd->arch.amd.root_table )
> return;
>
> - printk("p2m table has %d levels\n", hd->arch.paging_mode);
> - amd_dump_p2m_table_level(hd->arch.root_table, hd->arch.paging_mode, 0, 0);
> + printk("p2m table has %d levels\n", hd->arch.amd.paging_mode);
> + amd_dump_p2m_table_level(hd->arch.amd.root_table,
> + hd->arch.amd.paging_mode, 0, 0);
At least where you touch the format string anyway, converting %d
to %u where you converted fron plain int to unsigned int would be
nice.
Jan
next prev parent reply other threads:[~2020-08-03 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 12:29 [PATCH v3 00/11] IOMMU cleanup Paul Durrant
2020-08-03 12:29 ` [PATCH v3 01/11] x86/iommu: re-arrange arch_iommu to separate common fields Paul Durrant
2020-08-03 15:53 ` Jan Beulich [this message]
2020-08-03 12:29 ` [PATCH v3 02/11] x86/iommu: add common page-table allocator Paul Durrant
2020-08-03 15:58 ` Jan Beulich
2020-08-03 16:17 ` Durrant, Paul
2020-08-03 12:29 ` [PATCH v3 03/11] x86/iommu: convert VT-d code to use new page table allocator Paul Durrant
2020-08-03 16:03 ` Jan Beulich
2020-08-03 12:29 ` [PATCH v3 04/11] x86/iommu: convert AMD IOMMU " Paul Durrant
2020-08-03 16:05 ` Jan Beulich
2020-08-03 12:29 ` [PATCH v3 05/11] iommu: remove unused iommu_ops method and tasklet Paul Durrant
2020-08-03 16:06 ` Jan Beulich
2020-08-03 12:29 ` [PATCH v3 06/11] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail Paul Durrant
2020-08-03 12:29 ` [PATCH v3 07/11] iommu: make map, unmap and flush all take both an order and a count Paul Durrant
2020-08-03 12:29 ` [PATCH v3 08/11] remove remaining uses of iommu_legacy_map/unmap Paul Durrant
2020-08-03 12:29 ` [PATCH v3 09/11] common/grant_table: batch flush I/O TLB Paul Durrant
2020-08-03 12:29 ` [PATCH v3 10/11] iommu: remove the share_p2m operation Paul Durrant
2020-08-03 12:29 ` [PATCH v3 11/11] iommu: stop calling IOMMU page tables 'p2m tables' Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5a0a65-81aa-2c1f-c98a-5e6fd54ba3df@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=kevin.tian@intel.com \
--cc=lukasz.hawrylko@linux.intel.com \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).