From: Toshi Kani <toshi.kani@hpe.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: jgross@suse.com, mcgrof@suse.com, x86@kernel.org,
linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com,
hpa@zytor.com, xen-devel@lists.xenproject.org,
tglx@linutronix.de, bp@suse.de, elliott@hpe.com
Subject: Re: [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes
Date: Tue, 29 Mar 2016 08:19:27 -0600 [thread overview]
Message-ID: <1459261167.6393.668.camel__38160.5945913636$1459258136$gmane$org@hpe.com> (raw)
In-Reply-To: <20160329103442.GA12645@gmail.com>
On Tue, 2016-03-29 at 12:34 +0200, Ingo Molnar wrote:
> * Toshi Kani <toshi.kani@hpe.com> wrote:
>
> > A Xorg failure on qemu32 was reported as a regression [1] caused by
> > 'commit 9cd25aac1f44 ("x86/mm/pat: Emulate PAT when it is disabled")'.
> > This patch-set fixes the regression.
> >
> > Negative effects of this regression were two failures [2] in Xorg on
> > QEMU with QEMU CPU model "qemu32" (-cpu qemu32), which were triggered
> > by the fact that its virtual CPU does not support MTRR.
> > #1. copy_process() failed in the check in reserve_pfn_range()
> > #2. error path in copy_process() then hit WARN_ON_ONCE in
> > untrack_pfn().
> >
> > These negative effects are caused by two separate bugs, but they can be
> > addressed in separate patches. This patch-set addresses the root
> > cause, a long-standing PAT initialization issue.
> >
> > Please see the changelog in patch 4/7 for the details of the issue.
> >
> > - Patch 1-2 make necessary enhancement to PAT for the fix without
> > breaking Xen.
> > - Patch 3 is cleanup.
> > - Patch 4 fixes the regression.
> > - Patch 5 fixes an MTRR issue related with PAT init.
> > - Patch 6 removes PAT init code from Xen.
> > - Patch 7 adds PAT init to documentation.
> >
> > [1]: https://lkml.org/lkml/2016/3/3/828
> > [2]: https://lkml.org/lkml/2016/3/4/775
>
> The changelogs are much improved, I've applied these patches to
> tip:x86/mm, thanks Toshi!
Great! Thanks for all valuable comments!
> > I'd appreciate if someone can test this patch-set on Xen to verify that
> > there is no change in "x86/PAT: Configuration [0-7] .." message in
> > dmesg.
>
> So I don't have a Xen setup, but hopefully such testing will happen once
> these changes show up in linux-next, tomorrow or so.
I will address if any issue is found in testing.
-Toshi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-29 13:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458769323-24491-1-git-send-email-toshi.kani@hpe.com>
2016-03-23 21:41 ` [PATCH v3 1/7] x86/mm/pat: Add support of non-default PAT MSR setting Toshi Kani
2016-03-23 21:41 ` [PATCH v3 2/7] x86/mm/pat: Add pat_disable() interface Toshi Kani
2016-03-23 21:41 ` [PATCH v3 3/7] x86/mm/pat: Replace cpu_has_pat with boot_cpu_has Toshi Kani
2016-03-23 21:42 ` [PATCH v3 4/6] x86/mtrr: Fix Xorg crashes in Qemu sessions Toshi Kani
2016-03-23 21:42 ` [PATCH v3 5/7] x86/mtrr: Fix PAT init handling when MTRR is disabled Toshi Kani
2016-03-23 21:42 ` [PATCH v3 6/7] x86/xen, pat: Remove PAT table init code from Xen Toshi Kani
2016-03-23 21:42 ` [PATCH v3 7/7] x86/pat: Document PAT initialization Toshi Kani
2016-03-29 10:34 ` [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes Ingo Molnar
[not found] ` <20160329103442.GA12645@gmail.com>
2016-03-29 14:19 ` Toshi Kani [this message]
[not found] ` <1459261167.6393.668.camel@hpe.com>
2016-03-29 14:46 ` Boris Ostrovsky
[not found] ` <56FA9563.60401@oracle.com>
2016-03-29 15:49 ` Toshi Kani
[not found] ` <1459266567.6393.669.camel@hpe.com>
2016-03-30 18:02 ` Luis R. Rodriguez
[not found] ` <CAB=NE6VZD3gJicAzm3068APmVeKmFdF-gavNjEoVCz51hV262g@mail.gmail.com>
2016-03-30 18:58 ` Konrad Rzeszutek Wilk
2016-03-30 20:10 ` [LKP] " Luis R. Rodriguez
[not found] ` <CAB=NE6V2BOfkM5B8E+YULqrjqh_QaXOtBgyqpvBoku-73N4X-Q@mail.gmail.com>
2016-03-30 20:29 ` Konrad Rzeszutek Wilk
2016-03-30 20:47 ` Luis R. Rodriguez
2016-03-23 21:41 Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1459261167.6393.668.camel__38160.5945913636$1459258136$gmane$org@hpe.com' \
--to=toshi.kani@hpe.com \
--cc=bp@suse.de \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).