From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, rusty@rustcorp.com.au, x86@kernel.org,
linux-kernel@vger.kernel.org, luto@amacapital.net,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
konrad.wilk@oracle.com, xen-devel@lists.xensource.com,
lguest@lists.ozlabs.org, andriy.shevchenko@linux.intel.com,
jlee@suse.com, glin@suse.com, matt@codeblueprint.co.uk,
andrew.cooper3@citrix.com, rjw@rjwysocki.net, lenb@kernel.org,
robert.moore@intel.com, lv.zheng@intel.com, toshi.kani@hp.com,
linux-acpi@vger.kernel.org, kozerkov@parallels.com,
josh@joshtriplett.org, joro@8bytes.org, tiwai@suse.de
Subject: Re: [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch
Date: Wed, 13 Apr 2016 17:17:20 +0200 [thread overview]
Message-ID: <20160413151720.GT1990@wotan.suse.de> (raw)
In-Reply-To: <20160413080132.GA9697@gmail.com>
On Wed, Apr 13, 2016 at 10:01:32AM +0200, Ingo Molnar wrote:
> > diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
> > index 329254373479..bf9fea2f4591 100644
> > --- a/arch/x86/include/uapi/asm/bootparam.h
> > +++ b/arch/x86/include/uapi/asm/bootparam.h
> > @@ -157,7 +157,42 @@ struct boot_params {
> > __u8 _pad9[276]; /* 0xeec */
> > } __attribute__((packed));
> >
> > -enum {
> > +/**
> > + * enum x86_hardware_subarch - x86 hardware subarchitecture
>
> Could you add some prominent warning here, like:
>
> > + * WARNING: the 'x86 subarch flag' is only used for legacy hacks, for platform
> > + * features that are not easily enumerated or discoverable. You should
> > + * not ever use this for new features.
With pleasure, added.
Luis
next prev parent reply other threads:[~2016-04-13 15:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 23:40 [PATCH v5 00/14] x86: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-04-13 8:01 ` Ingo Molnar
2016-04-13 15:17 ` Luis R. Rodriguez [this message]
2016-04-08 23:40 ` [PATCH v5 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 03/14] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-11 6:50 ` [Xen-devel] " Juergen Gross
2016-04-12 20:50 ` Luis R. Rodriguez
2016-04-13 22:49 ` Luis R. Rodriguez
2016-04-11 13:49 ` Boris Ostrovsky
2016-04-12 20:56 ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 06/14] x86/init: use a platform legacy quirk for ebda Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 08/14] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 11/14] pnpbios: replace paravirt_enabled() check with legacy device check Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 12/14] x86, ACPI: parse ACPI_FADT_LEGACY_DEVICES Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 13/14] x86/init: rename ebda code file Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-11 6:51 ` [Xen-devel] " Juergen Gross
2016-04-08 23:57 ` [PATCH v5 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-08 23:57 ` [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-08 23:57 ` [PATCH v5 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-13 8:44 ` Ingo Molnar
2016-04-13 15:45 ` Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-04-08 23:59 ` [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-09 0:00 ` [PATCH v5 00/14] x86: " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413151720.GT1990@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=glin@suse.com \
--cc=hpa@zytor.com \
--cc=jlee@suse.com \
--cc=joro@8bytes.org \
--cc=josh@joshtriplett.org \
--cc=konrad.wilk@oracle.com \
--cc=kozerkov@parallels.com \
--cc=lenb@kernel.org \
--cc=lguest@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=lv.zheng@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).